lib: rm circular deps

by:
- not requiring Lib into plot_config.js to log error
- rm useless Lib.log in lib/dates.js
- require lib/loggers.js directly instead of Lib in lib/search.js

Author: etpinard

src/lib/dates.js

@@ -12,8 +12,6 @@
 var d3 = require('d3');
 var isNumeric = require('fast-isnumeric');
 
-var Lib = require('../lib');
-
 
 /**
  * dateTime2ms - turn a date object or string s of the form
@@ -123,14 +121,11 @@ function lpad(val, digits) {
  * If rng is big, the later parts of time will be omitted
  */
 exports.ms2DateTime = function(ms, r) {
-    if(typeof(d3) === 'undefined') {
-        Lib.error('d3 is not defined.');
-        return;
-    }
-
     if(!r) r = 0;
+
     var d = new Date(ms),
         s = d3.time.format('%Y-%m-%d')(d);
+
     if(r < 7776000000) {
         // <90 days: add hours
         s += ' ' + lpad(d.getHours(), 2);

src/lib/loggers.js

@@ -8,6 +8,8 @@
 
 'use strict';
 
+/* eslint-disable no-console */
+
 var config = require('../plot_api/plot_config');
 
 var loggers = module.exports = {};
@@ -18,7 +20,6 @@ var loggers = module.exports = {};
  * ------------------------------------------
  */
 
-/* eslint-disable no-console */
 loggers.log = function() {
     if(config.logging > 1) {
         var messages = ['LOG:'];
@@ -62,4 +63,3 @@ loggers.error = function() {
         console.error.apply(console, arguments);
     }
 };
-/* eslint-enable no-console */

src/lib/search.js

@@ -10,8 +10,7 @@
 'use strict';
 
 var isNumeric = require('fast-isnumeric');
-
-var Lib = require('../lib');
+var loggers = require('./loggers');
 
 
 /**
@@ -47,7 +46,7 @@ exports.findBin = function(val, bins, linelow) {
             if(test(bins[n], val)) n1 = n + 1;
             else n2 = n;
         }
-        if(c > 90) Lib.log('Long binary search...');
+        if(c > 90) loggers.log('Long binary search...');
         return n1 - 1;
     }
 };

src/plot_api/plot_config.js

@@ -8,7 +8,7 @@
 
 'use strict';
 
-var Lib = require('../lib');
+/* eslint-disable no-console */
 
 /**
  * This will be transferred over to gd and overridden by
@@ -98,10 +98,14 @@ module.exports = {
 };
 
 // where and how the background gets set can be overridden by context
-// so we define the default (plotlyjs) behavior here
+// so we define the default (plotly.js) behavior here
 function defaultSetBackground(gd, bgColor) {
     try {
         gd._fullLayout._paper.style('background', bgColor);
     }
-    catch(e) { Lib.error(e); }
+    catch(e) {
+        if(module.exports.logging > 0) {
+            console.error(e);
+        }
+    }
 }