🔒 scattergl transform behavior

Author: etpinard

test/jasmine/tests/gl2d_click_test.js

@@ -689,4 +689,27 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
         .catch(failTest)
         .then(done);
     });
+
+    it('should work on trace with enabled transforms', function(done) {
+        var fig = Lib.extendDeep({}, require('@mocks/gl2d_transforms.json'));
+        fig.layout.dragmode = 'select';
+        fig.layout.margin = {t: 0, b: 0, l: 0, r: 0};
+        fig.layout.height = 500;
+        fig.layout.width = 500;
+        gd = createGraphDiv();
+
+        Plotly.plot(gd, fig)
+        .then(delay(100))
+        .then(function() { return select([[100, 100], [250, 250]]); })
+        .then(function(eventData) {
+            assertEventData(eventData, {
+                points: [
+                    { x: 3, y: 4 },
+                    { x: 2, y: 4 }
+                ]
+            });
+        })
+        .catch(failTest)
+        .then(done);
+    });
 });

test/jasmine/tests/gl2d_plot_interact_test.js

@@ -962,6 +962,72 @@ describe('@gl Test gl2d plots', function() {
         .catch(failTest)
         .then(done);
     });
+
+    it('should handle transform traces properly (calcTransform case)', function(done) {
+        spyOn(ScatterGl, 'calc').and.callThrough();
+
+        Plotly.plot(gd, [{
+            type: 'scattergl',
+            x: [1, 2, 3],
+            y: [1, 2, 1],
+            transforms: [{
+                type: 'filter',
+                target: 'x',
+                operation: '>',
+                value: 1
+            }]
+        }])
+        .then(function() {
+            expect(ScatterGl.calc).toHaveBeenCalledTimes(2);
+
+            var opts = gd.calcdata[0][0].t._scene.markerOptions;
+            // length === 2 before #2677
+            expect(opts.length).toBe(1);
+
+            return Plotly.restyle(gd, 'selectedpoints', [[1]]);
+        })
+        .then(function() {
+            // was === 1 before #2677
+            var scene = gd.calcdata[0][0].t._scene;
+            expect(scene.selectBatch[0]).toEqual([0]);
+        })
+        .catch(failTest)
+        .then(done);
+    });
+
+    it('should handle transform traces properly (default transform case)', function(done) {
+        spyOn(ScatterGl, 'calc').and.callThrough();
+
+        Plotly.plot(gd, [{
+            type: 'scattergl',
+            x: [1, 2, 3],
+            y: [1, 2, 1],
+            transforms: [{
+                type: 'groupby',
+                groups: ['a', 'b', 'a']
+            }]
+        }])
+        .then(function() {
+            // twice per 'expanded' trace
+            expect(ScatterGl.calc).toHaveBeenCalledTimes(4);
+
+            // 'scene' from opts0 and opts1 is linked to the same object,
+            // which has two items, one for each 'expanded' trace
+            var opts0 = gd.calcdata[0][0].t._scene.markerOptions;
+            expect(opts0.length).toBe(2);
+
+            var opts1 = gd.calcdata[1][0].t._scene.markerOptions;
+            expect(opts1.length).toBe(2);
+
+            return Plotly.restyle(gd, 'selectedpoints', [[1]]);
+        })
+        .then(function() {
+            var scene = gd.calcdata[0][0].t._scene;
+            expect(scene.selectBatch).toEqual([[], [0]]);
+        })
+        .catch(failTest)
+        .then(done);
+    });
 });
 
 describe('Test scattergl autorange:', function() {