fix test failures - and simplify handleArrayContainerDefaults even more 🎉

Author: alexcjohnson

src/components/shapes/draw.js

@@ -66,7 +66,7 @@ function drawOne(gd, index) {
         .selectAll('.shapelayer [data-index="' + index + '"]')
         .remove();
 
-    var options = gd._fullLayout.shapes[index];
+    var options = gd._fullLayout.shapes[index] || {};
 
     // this shape is gone - quit now after deleting it
     // TODO: use d3 idioms instead of deleting and redrawing every time

src/components/sliders/defaults.js

@@ -94,7 +94,7 @@ function sliderDefaults(sliderIn, sliderOut, layoutOut) {
     coerce('minorticklen');
 }
 
-function stepDefaults(valueIn, valueOut, sliderOut, opts, itemOpts) {
+function stepDefaults(valueIn, valueOut) {
     function coerce(attr, dflt) {
         return Lib.coerce(valueIn, valueOut, stepAttrs, attr, dflt);
     }
@@ -108,7 +108,7 @@ function stepDefaults(valueIn, valueOut, sliderOut, opts, itemOpts) {
     if(visible) {
         coerce('method');
         coerce('args');
-        var label = coerce('label', 'step-' + itemOpts.index);
+        var label = coerce('label', 'step-' + valueOut._index);
         coerce('value', label);
         coerce('execute');
     }

src/plots/array_container_defaults.js

@@ -36,8 +36,6 @@ var Template = require('../plot_api/plot_template');
  *          - itemOut {object} item in full layout
  *          - parentObj {object} (as in closure)
  *          - opts {object} (as in closure)
- *          - itemOpts {object}
- *              - index {integer}
  * N.B.
  *
  *  - opts is passed to handleItemDefaults so it can also store
@@ -57,7 +55,6 @@ module.exports = function handleArrayContainerDefaults(parentObjIn, parentObjOut
 
     for(i = 0; i < contIn.length; i++) {
         var itemIn = contIn[i];
-        var itemOpts = {};
 
         if(!Lib.isPlainObject(itemIn)) {
             itemOut = templater.newItem({});
@@ -70,7 +67,7 @@ module.exports = function handleArrayContainerDefaults(parentObjIn, parentObjOut
         itemOut._index = i;
 
         if(itemOut[inclusionAttr] !== false) {
-            opts.handleItemDefaults(itemIn, itemOut, parentObjOut, opts, itemOpts);
+            opts.handleItemDefaults(itemIn, itemOut, parentObjOut, opts);
         }
 
         contOut.push(itemOut);