Removed console.logs from tests

Author: nicholas-esterer

test/jasmine/assets/domain_ref/components.js

@@ -13,10 +13,8 @@
 var Plotly = require('../../../../lib/index');
 var d3 = require('d3');
 var pixelCalc = require('../../assets/pixel_calc');
-var getSVGElemScreenBBox = require(
-    '../../assets/get_svg_elem_screen_bbox');
-var SVGTools = require(
-    '../../assets/svg_tools');
+var getSVGElemScreenBBox = require('../../assets/get_svg_elem_screen_bbox');
+// var SVGTools = require('../../assets/svg_tools');
 var Lib = require('../../../../src/lib');
 var Axes = require('../../../../src/plots/cartesian/axes');
 var axisIds = require('../../../../src/plots/cartesian/axis_ids');
@@ -28,6 +26,19 @@ var testMock = require('./domain_ref_base.json');
 // NOTE: this tolerance is in pixels
 var EQUALITY_TOLERANCE = 1e-2;
 
+// Make an array from a finite iterable (for environments not having
+// Array.from)
+function iterToArray(iter) {
+    var a = [];
+    do {
+        var v = iter.next();
+        // when done is true v.value is undefined
+        if(v.done) { return a; }
+        a.push(v.value);
+    } while(true);
+    return a;
+}
+
 // some made-up values for testing
 // NOTE: The pixel values are intentionally set so that 2*pixel is never greater
 // than the mock's margin. This is so that annotations are not unintentionally
@@ -492,8 +503,8 @@ function checkAROPosition(gd, aro) {
     var aroPathBBox = getSVGElemScreenBBox(aroPath);
     var aroBBox = shapeToBBox(gd.layout, aro);
     var ret = compareBBoxes(aroBBox, aroPathBBox);
-    console.log('aroBBox: ' + JSON.stringify(aroBBox));
-    console.log('aroPathBBox: ' + JSON.stringify(SVGTools.svgRectToObj(aroPathBBox)));
+    // console.log('aroBBox: ' + JSON.stringify(aroBBox));
+    // console.log('aroPathBBox: ' + JSON.stringify(SVGTools.svgRectToObj(aroPathBBox)));
     return ret;
 }
 
@@ -507,7 +518,7 @@ function testShape(
     yaroPos,
     aroType
 ) {
-    console.log('gd.layout: ', JSON.stringify(gd.layout));
+    // console.log('gd.layout: ', JSON.stringify(gd.layout));
     var aro = {
         type: aroType,
         line: {
@@ -522,7 +533,7 @@ function testShape(
     // change to log axes if need be
     logAxisIfAxType(gd.layout, layout, 'x' + xAxNum, xaxisType);
     logAxisIfAxType(gd.layout, layout, 'y' + yAxNum, yaxisType);
-    console.log('layout: ', JSON.stringify(layout));
+    // console.log('layout: ', JSON.stringify(layout));
     return Plotly.relayout(gd, layout)
         .then(function(gd) {
             return checkAROPosition(gd, aro);
@@ -699,7 +710,7 @@ function comboTestDescriptions(testCombos, desribe) {
 }
 
 function annotationTestCombos() {
-    var testCombos = Array.from(iterable.cartesianProduct([
+    var testCombos = iterToArray(iterable.cartesianProduct([
         axisTypes, axisTypes, axisPairs, aroPositionsX, aroPositionsY, arrowAxis
     ]));
     testCombos = testCombos.map(
@@ -722,7 +733,7 @@ function annotationTestDescriptions() {
 
 
 function imageTestCombos() {
-    var testCombos = Array.from(iterable.cartesianProduct(
+    var testCombos = iterToArray(iterable.cartesianProduct(
         [
             axisTypes, axisTypes, axisPairs,
             // axis reference types are contained in here
@@ -749,7 +760,7 @@ function imageTestDescriptions() {
 }
 
 function shapeTestCombos() {
-    var testCombos = Array.from(iterable.cartesianProduct(
+    var testCombos = iterToArray(iterable.cartesianProduct(
         [
             axisTypes, axisTypes, axisPairs,
             // axis reference types are contained in here

test/jasmine/tests/domain_ref_interact_test.js

@@ -12,7 +12,7 @@ var delay = require('../assets/delay');
 var mouseEvent = require('../assets/mouse_event');
 // we have to use drag to move annotations for some reason
 var drag = require('../assets/drag');
-var SVGTools = require('../assets/svg_tools');
+// var SVGTools = require('../assets/svg_tools');
 
 // color of the rectangles
 var rectColor1 = 'rgb(10, 20, 30)';
@@ -24,17 +24,17 @@ var arrowColor2 = 'rgb(231, 200, 200)';
 
 var DELAY_TIME = 10;
 
-function svgRectToJSON(svgrect) {
-    return JSON.stringify(SVGTools.svgRectToObj(svgrect));
-}
+// function svgRectToJSON(svgrect) {
+//    return JSON.stringify(SVGTools.svgRectToObj(svgrect));
+// }
 
 function checkBBox(bboxBefore, bboxAfter, moveX, moveY) {
     // We print out the objects for sanity, because sometimes Jasmine says a
     // test passed when it actually did nothing!
-    console.log('bboxBefore', svgRectToJSON(bboxBefore));
-    console.log('bboxAfter', svgRectToJSON(bboxAfter));
-    console.log('moveX', moveX);
-    console.log('moveY', moveY);
+    // console.log('bboxBefore', svgRectToJSON(bboxBefore));
+    // console.log('bboxAfter', svgRectToJSON(bboxAfter));
+    // console.log('moveX', moveX);
+    // console.log('moveY', moveY);
     expect(bboxAfter.x).toBeCloseTo(bboxBefore.x + moveX, 2);
     expect(bboxAfter.y).toBeCloseTo(bboxBefore.y + moveY, 2);
 }
@@ -84,7 +84,7 @@ function testAnnotationMoveLabel(objectColor, moveX, moveY) {
         pos0: dragPos0(bboxBefore)
     };
     optLabelDrag.dpos = [moveX, moveY];
-    console.log('optLabelDrag', optLabelDrag);
+    // console.log('optLabelDrag', optLabelDrag);
     // drag the label, this will make the arrow rotate around the arrowhead
     return (new Promise(function(resolve) {
         drag(optLabelDrag); resolve();
@@ -115,7 +115,7 @@ function testAnnotationMoveWhole(objectColor, arrowColor, moveX, moveY, corner)
         pos0: dragPos0(arrowBBoxBefore, corner)
     };
     optArrowDrag.dpos = [moveX, moveY];
-    console.log('optArrowDrag', optArrowDrag);
+    // console.log('optArrowDrag', optArrowDrag);
     // drag the whole annotation
     (new Promise(function(resolve) {
         drag(optArrowDrag); resolve();

test/jasmine/tests/domain_ref_test.js

@@ -25,7 +25,7 @@ function makeTests(component, filter) {
         });
         descriptions.forEach(function(d, i) {
             it(d, function(done) {
-                console.log('testing ' + d);
+                // console.log('testing ' + d);
                 gd.id = 'graph-' + i;
                 tests[i](function(v) {
                     expect(v).toBe(true);