make svg 'ascent' and 'descent' props part of every plotly icons

Author: etpinard

src/components/modebar/index.js

@@ -159,17 +159,17 @@ proto.createButton = function (config) {
  * @Return {HTMLelement}
  */
 proto.createIcon = function (thisIcon) {
-    var iconHeight = Icons.ascent - Icons.descent,
+    var iconHeight = thisIcon.ascent - thisIcon.descent,
         svgNS = 'http://www.w3.org/2000/svg',
         icon = document.createElementNS(svgNS, 'svg'),
         path = document.createElementNS(svgNS, 'path');
 
     icon.setAttribute('height', '1em');
-    icon.setAttribute('width', (thisIcon.width / iconHeight)+'em');
+    icon.setAttribute('width', (thisIcon.width / iconHeight) + 'em');
     icon.setAttribute('viewBox', [0, 0, thisIcon.width, iconHeight].join(' '));
 
     path.setAttribute('d', thisIcon.path);
-    path.setAttribute('transform', 'matrix(1 0 0 -1 0 ' + Icons.ascent + ')');
+    path.setAttribute('transform', 'matrix(1 0 0 -1 0 ' + thisIcon.ascent + ')');
     icon.appendChild(path);
 
     return icon;

tasks/util/pull_font_svg.js

@@ -10,15 +10,16 @@ module.exports = function pullFontSVG(data, pathOut) {
 
         var font_obj = result.svg.defs[0].font[0],
             default_width = Number(font_obj.$['horiz-adv-x']),
-            chars = {
-                ascent: Number(font_obj['font-face'][0].$.ascent),
-                descent: Number(font_obj['font-face'][0].$.descent)
-            };
+            ascent = Number(font_obj['font-face'][0].$.ascent),
+            descent = Number(font_obj['font-face'][0].$.descent),
+            chars = {};
 
         font_obj.glyph.forEach(function(glyph) {
             chars[glyph.$['glyph-name']] = {
                 width: Number(glyph.$['horiz-adv-x']) || default_width,
-                path: glyph.$.d
+                path: glyph.$.d,
+                ascent: ascent,
+                descent: descent
             };
         });