no false option for groupclick

Author: archmoj

src/components/legend/attributes.js

@@ -110,14 +110,13 @@ module.exports = {
     },
     groupclick: {
         valType: 'enumerated',
-        values: ['toggleitem', 'togglegroup', false],
+        values: ['toggleitem', 'togglegroup'],
         dflt: 'togglegroup',
         editType: 'legend',
         description: [
             'Determines the behavior on legend group item click.',
             '*toggleitem* toggles the visibility of the individual item clicked on the graph.',
-            '*togglegroup* toggles the visibility of all items in the same legendgroup as the item clicked on the graph.',
-            '*false* disables legend group click interactions.'
+            '*togglegroup* toggles the visibility of all items in the same legendgroup as the item clicked on the graph.'
         ].join(' ')
     },
     x: {

src/components/legend/handle_click.js

@@ -151,8 +151,6 @@ module.exports = function handleClick(g, gd, numClicks) {
             }
 
             if(hasLegendgroup) {
-                if(groupClick === false) return;
-
                 if(toggleGroup) {
                     for(i = 0; i < fullData.length; i++) {
                         if(fullData[i].visible !== false && fullData[i].legendgroup === legendgroup) {
@@ -201,7 +199,6 @@ module.exports = function handleClick(g, gd, numClicks) {
                         // N.B. consider traces that have a set legendgroup as toggleable
                         notInLegend = (fullData[i].showlegend !== true && !fullData[i].legendgroup);
                         isInGroup = isClicked || (hasLegendgroup && fullData[i].legendgroup === legendgroup);
-                        if(isInGroup && groupClick === false) continue;
                         setVisibility(fullData[i], ((isInGroup && toggleGroup) || notInLegend) ? true : otherState);
                         break;
                 }

test/plot-schema.json

@@ -2684,14 +2684,13 @@
      }
     },
     "groupclick": {
-     "description": "Determines the behavior on legend group item click. *toggleitem* toggles the visibility of the individual item clicked on the graph. *togglegroup* toggles the visibility of all items in the same legendgroup as the item clicked on the graph. *false* disables legend group click interactions.",
+     "description": "Determines the behavior on legend group item click. *toggleitem* toggles the visibility of the individual item clicked on the graph. *togglegroup* toggles the visibility of all items in the same legendgroup as the item clicked on the graph.",
      "dflt": "togglegroup",
      "editType": "legend",
      "valType": "enumerated",
      "values": [
       "toggleitem",
-      "togglegroup",
-      false
+      "togglegroup"
      ]
     },
     "itemclick": {