Skip to content

Commit 7a289c5

Browse files
committed
revise no-new-func tests
1 parent d2d03c0 commit 7a289c5

File tree

3 files changed

+2
-32
lines changed

3 files changed

+2
-32
lines changed

.circleci/config.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -407,10 +407,7 @@ jobs:
407407
name: Test plotly bundles againt unexpected characters
408408
command: npm run no-bad-char
409409
- run:
410-
name: Display function constructors in plotly.js bundle
411-
command: npm run log-new-func
412-
- run:
413-
name: Test certain bundles against function constructors
410+
name: Display function constructors in all bundles
414411
command: npm run no-new-func
415412
- run:
416413
name: Test plotly bundles against es6

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
"cibuild": "npm run empty-dist && npm run preprocess && node tasks/cibundle.js",
3838
"lint": "eslint --version && eslint .",
3939
"lint-fix": "eslint . --fix || true",
40-
"log-new-func": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-new-func: error}' dist/plotly.js 2>&1 | ./tasks/show_eval_lines.sh",
4140
"no-new-func": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-new-func: warn}' $(find dist -type f -iname '*.js')",
4241
"no-bad-char": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-misleading-character-class: error}' $(find dist -type f -iname '*.js' | grep plotly)",
4342
"no-dup-keys": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-dupe-keys: error}' $(find dist -type f -iname '*.js' | grep plotly)",
@@ -59,7 +58,7 @@
5958
"baseline": "node test/image/make_baseline.js",
6059
"noci-baseline": "npm run cibuild && ./tasks/noci_test.sh image && git checkout dist && echo 'Please do not commit unless the change was expected!'",
6160
"preversion": "check-node-version --node 16 --npm 7 && npm-link-check && npm ls --prod --all",
62-
"version": "npm run build && npm run no-bad-char && npm run no-new-func && git add -A lib dist build src/version.js",
61+
"version": "npm run build && npm run no-bad-char && git add -A lib dist build src/version.js",
6362
"postversion": "node -e \"console.log('Version bumped and committed. If ok, run: git push && git push --tags')\"",
6463
"postpublish": "node tasks/sync_packages.js",
6564
"postshrinkwrap": "chttps ."

tasks/show_eval_lines.sh

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)