rename glTrace ref on scattergl fullTrace to _glTrace

- ... as it should have been all along, non-attribute keys
  in fullTrace (and fullLayout for that matter) should be
  named with a leading underscore.
- scattergl glTrace ref is now consistent with
  the scattermapbox version

Author: etpinard

src/lib/index.js

@@ -451,7 +451,7 @@ lib.minExtend = function(obj1, obj2) {
     for(i = 0; i < keys.length; i++) {
         k = keys[i];
         v = obj1[k];
-        if(k.charAt(0) === '_' || typeof v === 'function' || k === 'glTrace') continue;
+        if(k.charAt(0) === '_' || typeof v === 'function') continue;
         else if(k === 'module') objOut[k] = v;
         else if(Array.isArray(v)) objOut[k] = v.slice(0, arrayLen);
         else if(v && (typeof v === 'object')) objOut[k] = lib.minExtend(obj1[k], obj2[k]);

src/traces/scattergl/convert.js

@@ -322,8 +322,8 @@ proto.update = function(options, cdscatter) {
     this.color = getTraceColor(options, {});
 
     // provide reference for selecting points
-    if(cdscatter && cdscatter[0] && !cdscatter[0].glTrace) {
-        cdscatter[0].glTrace = this;
+    if(cdscatter && cdscatter[0] && !cdscatter[0]._glTrace) {
+        cdscatter[0]._glTrace = this;
     }
 };
 

src/traces/scattergl/select.js

@@ -22,8 +22,8 @@ module.exports = function selectPoints(searchInfo, polygon) {
         x,
         y;
 
-    var scattergl = cd[0].glTrace;
-    var scene = cd[0].glTrace.scene;
+    var glTrace = cd[0]._glTrace;
+    var scene = glTrace.scene;
 
     var hasOnlyLines = (!subtypes.hasMarkers(trace) && !subtypes.hasText(trace));
     if(trace.visible !== true || hasOnlyLines) return;
@@ -53,7 +53,7 @@ module.exports = function selectPoints(searchInfo, polygon) {
     // highlight selected points here
     trace.selection = selection;
 
-    scattergl.update(trace, cd);
+    glTrace.update(trace, cd);
     scene.glplot.setDirty();
 
     return selection;