improve logic around button title and name

Author: etpinard

src/components/modebar/index.js

@@ -122,9 +122,8 @@ proto.createButton = function (config) {
     button.className = 'modebar-btn';
 
     var title = config.title;
-    if(title !== null && title !== false && title !== '') {
-        button.setAttribute('data-title', title || config.name);
-    }
+    if(title === undefined) title = config.name;
+    if(title || title === 0) button.setAttribute('data-title', title);
 
     if(config.attr !== undefined) button.setAttribute('data-attr', config.attr);
 

test/jasmine/tests/modebar_test.js

@@ -101,7 +101,7 @@ describe('ModeBar', function() {
             expect(checkBtnAttr(modeBar, 0, 'data-title')).toEqual('the title too');
         });
 
-        it('hides title to when title is set to null or \'\' or false', function() {
+        it('hides title to when title is falsy but not 0', function() {
             var modeBar;
 
             modeBar = createModeBar(getMockGraphInfo(), [[
@@ -118,6 +118,11 @@ describe('ModeBar', function() {
                 { name: 'button', title: false, click: noop }
             ]]);
             expect(checkBtnAttr(modeBar, 0, 'data-title')).toBe(null);
+
+            modeBar = createModeBar(getMockGraphInfo(), [[
+                { name: 'button', title: 0, click: noop }
+            ]]);
+            expect(checkBtnAttr(modeBar, 0, 'data-title')).toEqual('0');
         });
     });