resolved circular dependency by extracting the crawler

Author: monfera

src/lib/index.js

@@ -15,6 +15,7 @@ var lib = module.exports = {};
 
 lib.nestedProperty = require('./nested_property');
 lib.isPlainObject = require('./is_plain_object');
+lib.isValObject = require('./is_val_object');
 lib.isArray = require('./is_array');
 
 var coerceModule = require('./coerce');

src/lib/is_val_object.js

@@ -0,0 +1,15 @@
+/**
+* Copyright 2012-2016, Plotly, Inc.
+* All rights reserved.
+*
+* This source code is licensed under the MIT license found in the
+* LICENSE file in the root directory of this source tree.
+*/
+
+
+'use strict';
+
+// returns true for a valid value object and false for tree nodes in the attribute hierarchy
+module.exports = function(obj) {
+    return obj && obj.valType !== undefined;
+};

src/plot_api/crawler.js

@@ -0,0 +1,35 @@
+/**
+* Copyright 2012-2016, Plotly, Inc.
+* All rights reserved.
+*
+* This source code is licensed under the MIT license found in the
+* LICENSE file in the root directory of this source tree.
+*/
+
+
+'use strict';
+
+var Lib = require('../lib');
+
+var crawler = module.exports = {};
+
+crawler.IS_SUBPLOT_OBJ = '_isSubplotObj';
+crawler.IS_LINKED_TO_ARRAY = '_isLinkedToArray';
+crawler.DEPRECATED = '_deprecated';
+
+// list of underscore attributes to keep in schema as is
+crawler.UNDERSCORE_ATTRS = [crawler.IS_SUBPLOT_OBJ, crawler.IS_LINKED_TO_ARRAY, crawler.DEPRECATED];
+
+crawler.crawl = function(attrs, callback, specifiedLevel) {
+    var level = specifiedLevel || 0;
+    Object.keys(attrs).forEach(function(attrName) {
+        var attr = attrs[attrName];
+
+        if(crawler.UNDERSCORE_ATTRS.indexOf(attrName) !== -1) return;
+
+        callback(attr, attrName, attrs, level);
+
+        if(Lib.isValObject(attr)) return;
+        if(Lib.isPlainObject(attr)) crawler.crawl(attr, callback, level + 1);
+    });
+};

src/plot_api/plot_schema.js

@@ -13,6 +13,7 @@ var Plotly = require('../plotly');
 var Registry = require('../registry');
 var Plots = require('../plots/plots');
 var Lib = require('../lib');
+var crawler = require('./crawler');
 
 // FIXME polar attribute are not part of Plotly yet
 var polarAreaAttrs = require('../plots/polar/area_attributes');
@@ -23,13 +24,7 @@ var extendDeep = Lib.extendDeep;
 var extendDeepAll = Lib.extendDeepAll;
 
 var NESTED_MODULE = '_nestedModules',
-    COMPOSED_MODULE = '_composedModules',
-    IS_SUBPLOT_OBJ = '_isSubplotObj',
-    IS_LINKED_TO_ARRAY = '_isLinkedToArray',
-    DEPRECATED = '_deprecated';
-
-// list of underscore attributes to keep in schema as is
-var UNDERSCORE_ATTRS = [IS_SUBPLOT_OBJ, IS_LINKED_TO_ARRAY, DEPRECATED];
+    COMPOSED_MODULE = '_composedModules';
 
 var plotSchema = {
     traces: {},
@@ -56,23 +51,9 @@ PlotSchema.get = function() {
     return plotSchema;
 };
 
-PlotSchema.crawl = function (attrs, callback, specifiedLevel) {
-    var level = specifiedLevel || 0;
-    Object.keys(attrs).forEach(function(attrName) {
-        var attr = attrs[attrName];
-
-        if(UNDERSCORE_ATTRS.indexOf(attrName) !== -1) return;
+PlotSchema.crawl = crawler.crawl;
 
-        callback(attr, attrName, attrs, level);
-
-        if(PlotSchema.isValObject(attr)) return;
-        if(Lib.isPlainObject(attr)) PlotSchema.crawl(attr, callback, level + 1);
-    });
-};
-
-PlotSchema.isValObject = function(obj) {
-    return obj && obj.valType !== undefined;
-};
+PlotSchema.isValObject = Lib.isValObject;
 
 function getTraceAttributes(type) {
     var globalAttributes = Plots.attributes,
@@ -132,13 +113,13 @@ function getLayoutAttributes() {
     // FIXME polar layout attributes
     layoutAttributes = assignPolarLayoutAttrs(layoutAttributes);
 
-    // add IS_SUBPLOT_OBJ attribute
+    // add crawler.IS_SUBPLOT_OBJ attribute
     layoutAttributes = handleSubplotObjs(layoutAttributes);
 
     layoutAttributes = removeUnderscoreAttrs(layoutAttributes);
     mergeValTypeAndRole(layoutAttributes);
 
-    // generate IS_LINKED_TO_ARRAY structure
+    // generate crawler.IS_LINKED_TO_ARRAY structure
     handleLinkedToArray(layoutAttributes);
 
     plotSchema.layout = { layoutAttributes: layoutAttributes };
@@ -159,7 +140,7 @@ function getTransformAttributes(name) {
 function getDefs() {
     plotSchema.defs = {
         valObjects: Lib.valObjects,
-        metaKeys: UNDERSCORE_ATTRS.concat(['description', 'role'])
+        metaKeys: crawler.UNDERSCORE_ATTRS.concat(['description', 'role'])
     };
 }
 
@@ -242,7 +223,7 @@ function mergeValTypeAndRole(attrs) {
         }
     }
 
-    PlotSchema.crawl(attrs, callback);
+    crawler.crawl(attrs, callback);
 }
 
 // helper methods
@@ -268,7 +249,7 @@ function getModule(arg) {
 function removeUnderscoreAttrs(attributes) {
     Object.keys(attributes).forEach(function(k) {
         if(k.charAt(0) === '_' &&
-            UNDERSCORE_ATTRS.indexOf(k) === -1) delete attributes[k];
+            crawler.UNDERSCORE_ATTRS.indexOf(k) === -1) delete attributes[k];
     });
     return attributes;
 }
@@ -322,7 +303,7 @@ function handleSubplotObjs(layoutAttributes) {
                 isSubplotObj = subplotRegistry.attrRegex.test(k);
             }
 
-            if(isSubplotObj) layoutAttributes[k][IS_SUBPLOT_OBJ] = true;
+            if(isSubplotObj) layoutAttributes[k][crawler.IS_SUBPLOT_OBJ] = true;
         });
     });
 
@@ -332,17 +313,17 @@ function handleSubplotObjs(layoutAttributes) {
 function handleLinkedToArray(layoutAttributes) {
 
     function callback(attr, attrName, attrs) {
-        if(attr[IS_LINKED_TO_ARRAY] !== true) return;
+        if(attr[crawler.IS_LINKED_TO_ARRAY] !== true) return;
 
         // TODO more robust logic
         var itemName = attrName.substr(0, attrName.length - 1);
 
-        delete attr[IS_LINKED_TO_ARRAY];
+        delete attr[crawler.IS_LINKED_TO_ARRAY];
 
         attrs[attrName] = { items: {} };
         attrs[attrName].items[itemName] = attr;
         attrs[attrName].role = 'object';
     }
 
-    PlotSchema.crawl(layoutAttributes, callback);
+    crawler.crawl(layoutAttributes, callback);
 }

src/plots/plots.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-var PlotSchema = require('./../plot_api/plot_schema')
+var crawler = require('./../plot_api/crawler');
 var d3 = require('d3');
 var isNumeric = require('fast-isnumeric');
 
@@ -797,13 +797,13 @@ function applyTransforms(fullTrace, fullData, layout) {
 
             stack = stack.slice(0, level).concat([attrName]);
 
-            var splittableAttr = attr.valType === 'data_array' || attr.arrayOk === true
+            var splittableAttr = attr.valType === 'data_array' || attr.arrayOk === true;
             if(splittableAttr) {
                 arraySplitAttributes.push(stack.slice());
             }
         }
 
-        PlotSchema.crawl(trace._module.attributes, callback);
+        crawler.crawl(trace._module.attributes, callback);
 
         return arraySplitAttributes;
     });