Make 'is simple binding' false for non-length-one arrays

Author: rreusser

src/plots/command.js

@@ -201,15 +201,17 @@ exports.hasSimpleAPICommandBindings = function(gd, commandList, bindingsByValue)
         binding = bindings[0];
         var value = binding.value;
         if(Array.isArray(value)) {
-            value = value[0];
+            if(value.length === 1) {
+                value = value[0];
+            } else {
+                return false;
+            }
         }
         if(bindingsByValue) {
             bindingsByValue[value] = i;
         }
     }
 
-    if(i === n) return false;
-
     return refBinding;
 };
 

test/jasmine/tests/command_test.js

@@ -155,12 +155,17 @@ describe('Plots.hasSimpleAPICommandBindings', function() {
             args: [{'marker.color': 20}, [2, 1]]
         }]);
 
-        expect(isSimple).toEqual({
+        // See https://github.com/plotly/plotly.js/issues/1169 for an example of where
+        // this logic was a little too sophisticated. It's better to bail out and omit
+        // functionality than to get it wrong.
+        expect(isSimple).toEqual(false);
+
+        /* expect(isSimple).toEqual({
             type: 'data',
             prop: 'marker.color',
             traces: [ 1, 2 ],
             value: [ 10, 10 ]
-        });
+        });*/
     });
 });
 
@@ -508,6 +513,14 @@ describe('component bindings', function() {
         }).catch(fail).then(done);
     });
 
+    it('udpates bound components when the value changes', function(done) {
+        expect(gd.layout.sliders[0].active).toBe(0);
+
+        Plotly.restyle(gd, 'marker.color', 'ecru').then(function() {
+            expect(gd.layout.sliders[0].active).toBe(0);
+        }).catch(fail).then(done);
+    });
+
     it('udpates bound components when the computed value changes', function(done) {
         expect(gd.layout.sliders[0].active).toBe(0);