restyle: call manageArrayContainers on array-container updates

- at the moment that means 'on restyle involving transforms'

Author: etpinard

src/plot_api/plot_api.js

@@ -1414,9 +1414,6 @@ function _restyle(gd, aobj, _traces) {
             continue;
         }
 
-        // take no chances on transforms
-        if(ai.substr(0, 10) === 'transforms') flags.docalc = true;
-
         // set attribute in gd.data
         undoit[ai] = a0();
         for(i = 0; i < traces.length; i++) {
@@ -1556,6 +1553,10 @@ function _restyle(gd, aobj, _traces) {
                 }
                 helpers.swapXYData(cont);
             }
+            else if(Plots.dataArrayContainers.indexOf(param.parts[0]) !== -1) {
+                helpers.manageArrayContainers(param, newVal, undoit);
+                flags.docalc = true;
+            }
             // all the other ones, just modify that one attribute
             else param.set(newVal);
 

test/jasmine/tests/transform_multi_test.js

@@ -580,3 +580,70 @@ describe('multiple traces with transforms:', function() {
         });
     });
 });
+
+describe('restyle applied on transforms:', function() {
+    'use strict';
+
+    afterEach(destroyGraphDiv);
+
+    it('should be able', function(done) {
+        var gd = createGraphDiv();
+
+        var data = [{ y: [2, 1, 2] }];
+
+        var transform0 = {
+            type: 'filter',
+            target: 'y',
+            operation: '>',
+            value: 1
+        };
+
+        var transform1 = {
+            type: 'groupby',
+            groups: ['a', 'b', 'b']
+        };
+
+        Plotly.plot(gd, data).then(function() {
+            expect(gd.data.transforms).toBeUndefined();
+
+            return Plotly.restyle(gd, 'transforms[0]', transform0);
+        })
+        .then(function() {
+            var msg = 'to generate blank transform objects';
+
+            expect(gd.data[0].transforms[0]).toBe(transform0, msg);
+
+            // make sure transform actually works
+            expect(gd._fullData[0].y).toEqual([2, 2], msg);
+
+            return Plotly.restyle(gd, 'transforms[1]', transform1);
+        })
+        .then(function() {
+            var msg = 'to generate blank transform objects (2)';
+
+            expect(gd.data[0].transforms[0]).toBe(transform0, msg);
+            expect(gd.data[0].transforms[1]).toBe(transform1, msg);
+            expect(gd._fullData[0].y).toEqual([2], msg);
+
+            return Plotly.restyle(gd, 'transforms[0]', null);
+        })
+        .then(function() {
+            var msg = 'to remove transform objects';
+
+            expect(gd.data[0].transforms[0]).toBe(transform1, msg);
+            expect(gd.data[0].transforms[1]).toBeUndefined(msg);
+            expect(gd._fullData[0].y).toEqual([2], msg);
+            expect(gd._fullData[1].y).toEqual([1, 2], msg);
+
+            return Plotly.restyle(gd, 'transforms', null);
+        })
+        .then(function() {
+            var msg = 'to remove all transform objects';
+
+            expect(gd.data[0].transforms).toBeUndefined(msg);
+            expect(gd._fullData[0].y).toEqual([2, 1, 2], msg);
+        })
+        .then(done);
+    });
+
+});