add name to newshape and improve descriptions

Author: archmoj

src/components/shapes/attributes.js

@@ -295,7 +295,10 @@ module.exports = templatedArray('shape', {
             valType: 'string',
             dflt: '',
             editType: 'arraydraw',
-            description: 'Sets the text to display with shape.'
+            description: [
+                'Sets the text to display with shape.',
+                'It is also used for legend item if `name` is not provided.'
+            ].join(' ')
         },
         texttemplate: shapeTexttemplateAttrs({}, {keys: Object.keys(shapeLabelTexttemplateVars)}),
         font: fontAttrs({

src/components/shapes/draw_newshape/attributes.js

@@ -134,11 +134,22 @@ module.exports = overrideAll({
                 '*vertical* allows vertical extend.'
             ].join(' ')
         },
+
+        name: extendFlat({}, basePlotAttributes.name, {
+            description: [
+                'Sets new shape name.',
+                'The name appear as the legend item.'
+            ].join(' ')
+        }),
+
         label: {
             text: {
                 valType: 'string',
                 dflt: '',
-                description: 'Sets the text to display with the new shape.'
+                description: [
+                    'Sets the text to display with the new shape.',
+                    'It is also used for legend item if `name` is not provided.'
+                ].join(' ')
             },
             texttemplate: shapeTexttemplateAttrs({newshape: true}, {keys: Object.keys(shapeLabelTexttemplateVars)}),
             font: fontAttrs({

test/plot-schema.json

@@ -3650,7 +3650,7 @@
      },
      "role": "object",
      "text": {
-      "description": "Sets the text to display with the new shape.",
+      "description": "Sets the text to display with the new shape. It is also used for legend item if `name` is not provided.",
       "dflt": "",
       "editType": "none",
       "valType": "string"
@@ -3804,6 +3804,11 @@
       "valType": "number"
      }
     },
+    "name": {
+     "description": "Sets new shape name. The name appear as the legend item.",
+     "editType": "none",
+     "valType": "string"
+    },
     "opacity": {
      "description": "Sets the opacity of new shapes.",
      "dflt": 1,
@@ -7379,7 +7384,7 @@
        },
        "role": "object",
        "text": {
-        "description": "Sets the text to display with shape.",
+        "description": "Sets the text to display with shape. It is also used for legend item if `name` is not provided.",
         "dflt": "",
         "editType": "arraydraw",
         "valType": "string"