Merge pull request #2238 from plotly/gl2d-multisubplot-fix

Gl2d multisubplot fix for

Author: etpinard

package.json

@@ -74,7 +74,7 @@
     "gl-line3d": "^1.1.0",
     "gl-mat4": "^1.1.2",
     "gl-mesh3d": "^1.3.0",
-    "gl-plot2d": "^1.2.0",
+    "gl-plot2d": "^1.3.0",
     "gl-plot3d": "^1.5.4",
     "gl-pointcloud2d": "^1.0.0",
     "gl-scatter2d": "^1.3.2",

src/plots/gl2d/convert.js

@@ -86,7 +86,7 @@ function Axes2DOptions(scene) {
         [0, 0, 0, 1]
     ];
 
-    this.borderColor = [0, 0, 0, 0];
+    this.borderColor = false;
     this.backgroundColor = [0, 0, 0, 0];
 
     this.static = this.scene.staticPlot;

src/plots/gl2d/scene2d.js

@@ -118,6 +118,7 @@ proto.makeFramework = function() {
 
         var gl = getContext({
             canvas: liveCanvas,
+            preserveDrawingBuffer: true,
             premultipliedAlpha: true
         });
 
@@ -181,20 +182,24 @@ proto.toImage = function(format) {
     if(!format) format = 'png';
 
     this.stopped = true;
+
     if(this.staticPlot) this.container.appendChild(STATIC_CANVAS);
 
     // update canvas size
     this.updateSize(this.canvas);
 
-    // force redraw
-    this.glplot.setDirty();
-    this.glplot.draw();
 
     // grab context and yank out pixels
     var gl = this.glplot.gl,
         w = gl.drawingBufferWidth,
         h = gl.drawingBufferHeight;
 
+    // force redraw
+    gl.clearColor(1, 1, 1, 0);
+    gl.clear(gl.COLOR_BUFFER_BIT | gl.DEPTH_BUFFER_BIT);
+    this.glplot.setDirty();
+    this.glplot.draw();
+
     gl.bindFramebuffer(gl.FRAMEBUFFER, null);
 
     var pixels = new Uint8Array(w * h * 4);

src/traces/scattergl/select.js

@@ -23,6 +23,9 @@ module.exports = function selectPoints(searchInfo, polygon) {
         y;
 
     var glTrace = cd[0]._glTrace;
+
+    if(!glTrace) return;
+
     var scene = glTrace.scene;
 
     var hasOnlyLines = (!subtypes.hasMarkers(trace) && !subtypes.hasText(trace));