ohlc: don't force hovermode: 'closest'

- the default hovermode: 'x' now looks good after adding
  transformed hover text

Author: etpinard

src/traces/candlestick/transform.js

@@ -42,9 +42,7 @@ exports.transform = function transform(dataIn, state) {
         );
     }
 
-    // add a few layout features
-    var layout = state.layout;
-    helpers.addRangeSlider(layout);
+    helpers.addRangeSlider(state.layout);
 
     return dataOut;
 };

src/traces/ohlc/transform.js

@@ -44,10 +44,7 @@ exports.transform = function transform(dataIn, state) {
         );
     }
 
-    // add a few layout features
-    var layout = state.layout;
-    if(!layout.hovermode) layout.hovermode = 'closest';
-    helpers.addRangeSlider(layout);
+    helpers.addRangeSlider(state.layout);
 
     return dataOut;
 };
@@ -96,7 +93,15 @@ function makeTrace(traceIn, state, direction) {
     return traceOut;
 }
 
-// let scatter hoverPoint format 'x' coordinates, if desired
+// Let scatter hoverPoint format 'x' coordinates, if desired.
+//
+// Note that, this solution isn't perfect: it shows open and close
+// values at slightly different 'x' coordinates then the rest of the
+// segments, but is for more robust than calling `Axes.tickText` during
+// calcTransform.
+//
+// A future iteration should perhaps try to add a hook for transforms in
+// the hoverPoints handlers.
 function makeHoverInfo(traceIn) {
     var hoverinfo = traceIn.hoverinfo;
 

test/jasmine/tests/finance_test.js

@@ -251,8 +251,6 @@ describe('finance charts defaults:', function() {
 
         var out0 = _supply([trace0], layout0);
 
-        expect(out0.layout.hovermode).toEqual('closest');
-        expect(out0._fullLayout.hovermode).toEqual('closest');
         expect(out0.layout.xaxis.rangeslider).toBeDefined();
         expect(out0._fullLayout.xaxis.rangeslider.visible).toBe(true);