fix double click on min reversed and max reversed cases

Author: archmoj

src/components/modebar/buttons.js

@@ -274,11 +274,11 @@ function handleCartesian(gd, ev) {
                     if(ax._rangeInitial0 === undefined && ax._rangeInitial1 === undefined) {
                         aobj[axName + '.autorange'] = true;
                     } else if(ax._rangeInitial0 === undefined) {
-                        aobj[axName + '.autorange'] = 'min';
+                        aobj[axName + '.autorange'] = ax._autorangeInitial;
                         aobj[axName + '.range'] = [null, ax._rangeInitial1];
                     } else if(ax._rangeInitial1 === undefined) {
                         aobj[axName + '.range'] = [ax._rangeInitial0, null];
-                        aobj[axName + '.autorange'] = 'max';
+                        aobj[axName + '.autorange'] = ax._autorangeInitial;
                     } else {
                         aobj[axName + '.range'] = [ax._rangeInitial0, ax._rangeInitial1];
                     }

src/plots/cartesian/axes.js

@@ -330,9 +330,11 @@ axes.saveRangeInitial = function(gd, overwrite) {
             ax.range[1] !== ax._rangeInitial1
         );
 
-        if((isNew && ax.autorange !== true) || (overwrite && hasChanged)) {
-            ax._rangeInitial0 = ax.autorange === 'min' ? undefined : ax.range[0];
-            ax._rangeInitial1 = ax.autorange === 'max' ? undefined : ax.range[1];
+        var autorange = ax.autorange;
+        if((isNew && autorange !== true) || (overwrite && hasChanged)) {
+            ax._rangeInitial0 = (autorange === 'min' || autorange === 'max reversed') ? undefined : ax.range[0];
+            ax._rangeInitial1 = (autorange === 'max' || autorange === 'min reversed') ? undefined : ax.range[1];
+            ax._autorangeInitial = autorange;
             hasOneAxisChanged = true;
         }
     }

src/plots/cartesian/dragbox.js

@@ -826,14 +826,16 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
 
                 if(!ax.fixedrange) {
                     var axName = ax._name;
+
+                    var autorangeInitial = ax._autorangeInitial;
                     if(ax._rangeInitial0 === undefined && ax._rangeInitial1 === undefined) {
                         attrs[axName + '.autorange'] = true;
                     } else if(ax._rangeInitial0 === undefined) {
-                        attrs[axName + '.autorange'] = 'min';
+                        attrs[axName + '.autorange'] = autorangeInitial;
                         attrs[axName + '.range'] = [null, ax._rangeInitial1];
                     } else if(ax._rangeInitial1 === undefined) {
                         attrs[axName + '.range'] = [ax._rangeInitial0, null];
-                        attrs[axName + '.autorange'] = 'max';
+                        attrs[axName + '.autorange'] = autorangeInitial;
                     } else {
                         attrs[axName + '.range'] = [ax._rangeInitial0, ax._rangeInitial1];
                     }

test/jasmine/tests/click_test.js

@@ -1046,6 +1046,35 @@ describe('Test click interactions:', function() {
             })
             .then(done, done.fail);
         });
+
+        it('when set to \'reset+autorange\' (the default) should autosize on 1st and 2nd double clicks (case of partial ranges reversed)', function(done) {
+            mockCopy = setRanges(mockCopy);
+
+            Plotly.newPlot(gd, [{
+                y: [1, 2, 3, 4]}
+            ], {
+                xaxis: {range: [null, 1], autorange: 'max reversed'},
+                yaxis: {range: [3, null], autorange: 'min reversed'},
+                width: 600,
+                height: 600
+            }).then(function() {
+                expect(gd.layout.xaxis.range).toBeCloseToArray([3.2, 1]);
+                expect(gd.layout.yaxis.range).toBeCloseToArray([3, 0.8]);
+
+                return doubleClick(300, 300);
+            })
+            .then(function() {
+                expect(gd.layout.xaxis.range).toBeCloseToArray([3.2, -0.2]);
+                expect(gd.layout.yaxis.range).toBeCloseToArray([4.2, 0.8]);
+
+                return doubleClick(300, 300);
+            })
+            .then(function() {
+                expect(gd.layout.xaxis.range).toBeCloseToArray([3.2, 1]);
+                expect(gd.layout.yaxis.range).toBeCloseToArray([3, 0.8]);
+            })
+            .then(done, done.fail);
+        });
     });
 
     describe('zoom interactions', function() {