Fix conditional logic in legend height calculation

Author: camdecoster

src/components/legend/attributes.js

@@ -41,9 +41,8 @@ module.exports = {
             'Sets the max height (in px) of the legend, or max height ratio (reference height * ratio) if less than or equal to 1.',
             'Default value is: 0.5 for horizontal legends; 1 for vertical legends. The minimum allowed height is 30px.',
             'For a ratio of 0.5, the legend will take up to 50% of the reference height before displaying a scrollbar.',
-            'The reference height is the full layout height with the following exception: vertically oriented legends with',
-            'a `yref` of `"paper" located to the side of the plot. In this case, the reference height',
-            'is the plot height.'
+            'The reference height is the full layout height with the following exceptions: legends to the side of the plot',
+            'or vertically oriented legends with a `yref` of `"paper". In this case, the reference height is the plot height.'
         ].join(' ')
     },
     borderwidth: {

src/components/legend/draw.js

@@ -771,7 +771,7 @@ function computeLegendDimensions(gd, groups, traces, legendObj) {
 
     const { orientation, yref } = legendObj;
     let { maxheight } = legendObj;
-    const useFullLayoutHeight = (isBelowPlotArea || isAbovePlotArea) && !(orientation === "v" && yref === "paper")
+    const useFullLayoutHeight = isBelowPlotArea || isAbovePlotArea || !(orientation === "v" && yref === "paper")
     // Set default maxheight here since it depends on values passed in by user
     maxheight ||= useFullLayoutHeight ? 0.5 : 1;
     const heightToBeScaled = useFullLayoutHeight ? fullLayout.height : gs.h;

test/plot-schema.json

@@ -3451,7 +3451,7 @@
      "valType": "number"
     },
     "maxheight": {
-     "description": "Sets the max height (in px) of the legend, or max height ratio (reference height * ratio) if less than one. Default value is: 0.5 for horizontal legends; 1 for vertical legends. The minimum allowed height is 30px. For a ratio of 0.5, the legend will take up to 50% of the reference height before displaying a scrollbar. The reference height is the full layout height with the following exception: vertically oriented legends with a `yref` of `\"paper\"`, unless the legend is located above/below the plot. In this case, the reference height is the plot height.",
+     "description": "Sets the max height (in px) of the legend, or max height ratio (reference height * ratio) if less than or equal to 1. Default value is: 0.5 for horizontal legends; 1 for vertical legends. The minimum allowed height is 30px. For a ratio of 0.5, the legend will take up to 50% of the reference height before displaying a scrollbar. The reference height is the full layout height with the following exceptions: legends to the side of the plot or vertically oriented legends with a `yref` of `\"paper\". In this case, the reference height is the plot height.",
      "editType": "legend",
      "min": 0,
      "valType": "number"