Merge pull request #6181 from plotly/eslint-v8.14

archmoj · web-flow · commit 57dee2eae42d · 2022-05-09T07:04:23.000-04:00
Bump `eslint` to v8.14 and remove window `typeof` check in registry
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -133,7 +133,7 @@
     "deep-equal": "^2.0.5",
     "derequire": "^2.1.1",
     "ecstatic": "^4.1.4",
-    "eslint": "^8.10.0",
+    "eslint": "^8.14.0",
     "extra-iterable": "^2.5.22",
     "falafel": "^2.2.4",
     "fs-extra": "^10.1.0",
diff --git a/src/registry.js b/src/registry.js
@@ -276,7 +276,7 @@ function registerTraceModule(_module) {
     // add `PlotlyGeoAssets` global to stash references to all fetched
     // topojson / geojson data
     if((bpmName === 'geo' || bpmName === 'mapbox') &&
-        (typeof window !== undefined && window.PlotlyGeoAssets === undefined)
+        (window.PlotlyGeoAssets === undefined)
     ) {
         window.PlotlyGeoAssets = {topojson: {}};
     }

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ function registerTraceModule(_module) {`
`276`	`276`	// add `PlotlyGeoAssets` global to stash references to all fetched
`277`	`277`	`// topojson / geojson data`
`278`	`278`	`if((bpmName === 'geo' \|\| bpmName === 'mapbox') &&`
`279`		`- (typeof window !== undefined && window.PlotlyGeoAssets === undefined)`
	`279`	`+ (window.PlotlyGeoAssets === undefined)`
`280`	`280`	`) {`
`281`	`281`	`window.PlotlyGeoAssets = {topojson: {}};`
`282`	`282`	`}`