Merge pull request #1419 from plotly/more-syntax-tests

More syntax tests

Author: etpinard

package.json

@@ -125,6 +125,7 @@
     "open": "0.0.5",
     "prepend-file": "^1.3.1",
     "prettysize": "0.0.3",
+    "read-last-lines": "^1.1.0",
     "requirejs": "^2.3.1",
     "through2": "^2.0.3",
     "uglify-js": "^2.7.5",

src/traces/parcoords/shaders/pick_vertex.glsl

@@ -51,7 +51,7 @@ void main() {
     mat4 pB = mat4(p4, p5, p6, p7);
     mat4 pC = mat4(p8, p9, pa, pb);
     mat4 pD = mat4(pc, pd, pe, abs(pf));
-    
+
     float show = float(mshow(pA, loA, hiA) &&
                        mshow(pB, loB, hiB) &&
                        mshow(pC, loC, hiC) &&

src/traces/parcoords/shaders/vertex.glsl

@@ -51,7 +51,7 @@ void main() {
     mat4 pB = mat4(p4, p5, p6, p7);
     mat4 pC = mat4(p8, p9, pa, pb);
     mat4 pD = mat4(pc, pd, pe, abs(pf));
-    
+
     float show = float(mshow(pA, loA, hiA) &&
                        mshow(pB, loB, hiB) &&
                        mshow(pC, loC, hiC) &&

tasks/test_syntax.js

@@ -4,6 +4,7 @@ var fs = require('fs');
 var falafel = require('falafel');
 var glob = require('glob');
 var madge = require('madge');
+var readLastLines = require('read-last-lines');
 
 var constants = require('./util/constants');
 var srcGlob = path.join(constants.pathToSrc, '**/*.js');
@@ -17,6 +18,7 @@ var EXIT_CODE = 0;
 assertJasmineSuites();
 assertSrcContents();
 assertFileNames();
+assertTrailingNewLine();
 assertCircularDeps();
 
 
@@ -90,24 +92,80 @@ function assertSrcContents() {
 
 // check that all file names are in lower case
 function assertFileNames() {
+    var pattern = combineGlobs([
+        path.join(constants.pathToRoot, '*.*'),
+        path.join(constants.pathToSrc, '**/*.*'),
+        path.join(constants.pathToLib, '**/*.*'),
+        path.join(constants.pathToDist, '**/*.*'),
+        path.join(constants.pathToRoot, 'test', '**/*.*'),
+        path.join(constants.pathToRoot, 'tasks', '**/*.*'),
+        path.join(constants.pathToRoot, 'devtools', '**/*.*')
+    ]);
+
     var logs = [];
 
-    glob(combineGlobs([srcGlob, libGlob, testGlob, bundleTestGlob]), function(err, files) {
+    glob(pattern, function(err, files) {
         files.forEach(function(file) {
             var base = path.basename(file);
 
+            if(
+                base === 'README.md' ||
+                base === 'CONTRIBUTING.md' ||
+                base === 'CHANGELOG.md' ||
+                base === 'SECURITY.md' ||
+                file.indexOf('mathjax') !== -1
+            ) return;
+
             if(base !== base.toLowerCase()) {
                 logs.push([
-                    file, ' :',
+                    file, ':',
                     'has a file name containing some',
                     'non-lower-case characters'
-                ]);
+                ].join(' '));
             }
         });
 
         log('lower case only file names', logs);
     });
+}
+
+// check that all files have a trailing new line character
+function assertTrailingNewLine() {
+    var pattern = combineGlobs([
+        path.join(constants.pathToSrc, '**/*.glsl'),
+        path.join(constants.pathToRoot, 'test', 'image', 'mocks', '*')
+    ]);
+
+    var regexNewLine = /\r?\n$/;
+    var regexEmptyNewLine = /^\r?\n$/;
+    var promises = [];
+    var logs = [];
+
+    glob(pattern, function(err, files) {
+        files.forEach(function(file) {
+            var promise = readLastLines.read(file, 1);
 
+            promises.push(promise);
+
+            promise.then(function(lines) {
+                if(!regexNewLine.test(lines)) {
+                    logs.push([
+                        file, ':',
+                        'does not have a trailing new line character'
+                    ].join(' '));
+                } else if(regexEmptyNewLine.test(lines)) {
+                    logs.push([
+                        file, ':',
+                        'has more than one trailing new line'
+                    ].join(' '));
+                }
+            });
+        });
+
+        Promise.all(promises).then(function() {
+            log('trailing new line character', logs);
+        });
+    });
 }
 
 // check circular dependencies
@@ -137,6 +195,7 @@ function combineGlobs(arr) {
 function log(name, logs) {
     if(logs.length) {
         console.error('test-syntax error [' + name + ']');
+        console.error(logs.join('\n'));
         EXIT_CODE = 1;
     } else {
         console.log('ok ' + name);