Skip to content

Commit 5422da9

Browse files
committed
coerce 'cliponaxis' only when markers and/or text are present
1 parent 86067a6 commit 5422da9

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

src/traces/scatter/defaults.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
5757
var dfltHoverOn = [];
5858

5959
if(subTypes.hasMarkers(traceOut) || subTypes.hasText(traceOut)) {
60+
coerce('cliponaxis');
6061
coerce('marker.maxdisplayed');
6162
dfltHoverOn.push('points');
6263
}
@@ -75,7 +76,5 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
7576
errorBarsSupplyDefaults(traceIn, traceOut, defaultColor, {axis: 'y'});
7677
errorBarsSupplyDefaults(traceIn, traceOut, defaultColor, {axis: 'x', inherit: 'y'});
7778

78-
coerce('cliponaxis');
79-
8079
Lib.coerceSelectionMarkerOpacity(traceOut, coerce);
8180
};

src/traces/scatterpolar/defaults.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,13 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
5858
var dfltHoverOn = [];
5959

6060
if(subTypes.hasMarkers(traceOut) || subTypes.hasText(traceOut)) {
61-
// TODO update other scatter*/defaults
62-
// cliponaxis has no effect on `mode: 'lines'` traces
6361
coerce('cliponaxis');
64-
6562
coerce('marker.maxdisplayed');
6663
dfltHoverOn.push('points');
6764
}
6865

6966
coerce('fill');
7067

71-
// TODO time for a subTypes.hasFill
7268
if(traceOut.fill !== 'none') {
7369
handleFillColorDefaults(traceIn, traceOut, defaultColor, coerce);
7470
if(!subTypes.hasLines(traceOut)) handleLineShapeDefaults(traceIn, traceOut, coerce);

src/traces/scatterternary/defaults.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
8585
var dfltHoverOn = [];
8686

8787
if(subTypes.hasMarkers(traceOut) || subTypes.hasText(traceOut)) {
88+
coerce('cliponaxis');
8889
coerce('marker.maxdisplayed');
8990
dfltHoverOn.push('points');
9091
}
@@ -100,7 +101,5 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
100101
}
101102
coerce('hoveron', dfltHoverOn.join('+') || 'points');
102103

103-
coerce('cliponaxis');
104-
105104
Lib.coerceSelectionMarkerOpacity(traceOut, coerce);
106105
};

0 commit comments

Comments
 (0)