Merge pull request #817 from plotly/speedup-relink

Faster relink private keys

Author: etpinard

src/plots/plots.js

@@ -610,9 +610,9 @@ function relinkPrivateKeys(toContainer, fromContainer) {
 
             toContainer[k] = fromVal;
         }
-        else if(isArray(fromVal) && isArray(toVal)) {
+        else if(isArray(fromVal) && isArray(toVal) && isPlainObject(fromVal[0])) {
 
-            // recurse into arrays
+            // recurse into arrays containers
             for(var j = 0; j < fromVal.length; j++) {
                 if(isPlainObject(fromVal[j]) && isPlainObject(toVal[j])) {
                     relinkPrivateKeys(toVal[j], fromVal[j]);

test/jasmine/tests/plots_test.js

@@ -50,6 +50,8 @@ describe('Test Plots', function() {
 
             Plots.supplyDefaults(gd);
 
+            expect(gd._fullData[0].z).toBe(newData[0].z);
+            expect(gd._fullData[1].z).toBe(newData[1].z);
             expect(gd._fullData[1]._empties).toBe(oldFullData[1]._empties);
             expect(gd._fullLayout.scene._scene).toBe(oldFullLayout.scene._scene);
             expect(gd._fullLayout._plots).toBe(oldFullLayout._plots);