Skip to content

Commit 4df54d7

Browse files
committed
Revert "remove 'fill' and 'fillcolor' (for now):"
This reverts commit 9d3776e.
1 parent aab9536 commit 4df54d7

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/traces/scatterternary/attributes.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,11 @@ module.exports = {
8080
smoothing: scatterLineAttrs.smoothing
8181
},
8282
connectgaps: scatterAttrs.connectgaps,
83+
fill: extendFlat({}, scatterAttrs.fill, {
84+
values: ['none', 'tozeroa', 'tozerob', 'tozeroc',
85+
'tonexta', 'tonextb', 'tonextc']
86+
}),
87+
fillcolor: scatterAttrs.fillcolor,
8388
marker: {
8489
symbol: scatterMarkerAttrs.symbol,
8590
opacity: scatterMarkerAttrs.opacity,

src/traces/scatterternary/defaults.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ var handleMarkerDefaults = require('../scatter/marker_defaults');
1717
var handleLineDefaults = require('../scatter/line_defaults');
1818
var handleLineShapeDefaults = require('../scatter/line_shape_defaults');
1919
var handleTextDefaults = require('../scatter/text_defaults');
20+
var handleFillColorDefaults = require('../scatter/fillcolor_defaults');
2021

2122
var attributes = require('./attributes');
2223

@@ -84,8 +85,11 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
8485
coerce('marker.maxdisplayed');
8586
}
8687

87-
coerce('hoverinfo', (layout._dataLength === 1) ? 'a+b+c+text' : undefined);
88+
coerce('fill');
89+
if(traceOut.fill !== 'none') {
90+
handleFillColorDefaults(traceIn, traceOut, defaultColor, coerce);
91+
if(!subTypes.hasLines(traceOut)) handleLineShapeDefaults(traceIn, traceOut, coerce);
92+
}
8893

89-
// until 'fill' and 'fillcolor' are supported
90-
traceOut.fill = 'none';
94+
coerce('hoverinfo', (layout._dataLength === 1) ? 'a+b+c+text' : undefined);
9195
};

0 commit comments

Comments
 (0)