Merge pull request #1073 from plotly/transform-trace-dflt-name

Use trace gd.data index to determine dflt trace name

Author: etpinard

src/plots/plots.js

@@ -618,7 +618,7 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
 
     for(var i = 0; i < dataIn.length; i++) {
         var trace = dataIn[i],
-            fullTrace = plots.supplyTraceDefaults(trace, cnt, fullLayout);
+            fullTrace = plots.supplyTraceDefaults(trace, cnt, fullLayout, i);
 
         fullTrace.index = i;
         fullTrace._input = trace;
@@ -629,7 +629,7 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
 
             for(var j = 0; j < expandedTraces.length; j++) {
                 var expandedTrace = expandedTraces[j],
-                    fullExpandedTrace = plots.supplyTraceDefaults(expandedTrace, cnt, fullLayout);
+                    fullExpandedTrace = plots.supplyTraceDefaults(expandedTrace, cnt, fullLayout, i);
 
                 // mutate uid here using parent uid and expanded index
                 // to promote consistency between update calls
@@ -733,9 +733,9 @@ plots.supplyFrameDefaults = function(frameIn) {
     return frameOut;
 };
 
-plots.supplyTraceDefaults = function(traceIn, traceIndex, layout) {
+plots.supplyTraceDefaults = function(traceIn, traceOutIndex, layout, traceInIndex) {
     var traceOut = {},
-        defaultColor = Color.defaults[traceIndex % Color.defaults.length];
+        defaultColor = Color.defaults[traceOutIndex % Color.defaults.length];
 
     function coerce(attr, dflt) {
         return Lib.coerce(traceIn, traceOut, plots.attributes, attr, dflt);
@@ -752,7 +752,7 @@ plots.supplyTraceDefaults = function(traceIn, traceIndex, layout) {
 
     coerce('type');
     coerce('uid');
-    coerce('name', 'trace ' + traceIndex);
+    coerce('name', 'trace ' + traceInIndex);
 
     // coerce subplot attributes of all registered subplot types
     var subplotTypes = Object.keys(subplotsRegistry);

test/jasmine/tests/finance_test.js

@@ -220,6 +220,35 @@ describe('finance charts defaults:', function() {
         ]);
     });
 
+    it('trace *name* default should make reference to user data trace indices', function() {
+        var trace0 = Lib.extendDeep({}, mock0, {
+            type: 'ohlc'
+        });
+
+        var trace1 = { type: 'scatter' };
+
+        var trace2 = Lib.extendDeep({}, mock1, {
+            type: 'candlestick',
+        });
+
+        var trace3 = { type: 'bar' };
+
+        var out = _supply([trace0, trace1, trace2, trace3]);
+
+        var names = out._fullData.map(function(fullTrace) {
+            return fullTrace.name;
+        });
+
+        expect(names).toEqual([
+            'trace 0 - increasing',
+            'trace 0 - decreasing',
+            'trace 1',
+            'trace 2 - increasing',
+            'trace 2 - decreasing',
+            'trace 3'
+        ]);
+    });
+
     it('trace-wide styling should set default for corresponding per-direction styling', function() {
         function assertLine(cont, width, dash) {
             expect(cont.line.width).toEqual(width);