Merge pull request #5093 from plotly/fix3246-redo

archmoj · web-flow · commit 4ac68aa4c436 · 2020-08-21T10:40:09.000-04:00
Keep the size of gl2d markers constant when using different plotGlPixelRatio values
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -108,7 +108,7 @@
     "regl": "^1.6.1",
     "regl-error2d": "^2.0.11",
     "regl-line2d": "^3.0.18",
-    "regl-scatter2d": "3.1.9",
+    "regl-scatter2d": "3.2.0",
     "regl-splom": "^1.0.12",
     "right-now": "^1.0.0",
     "robust-orientation": "^1.1.3",
diff --git a/src/traces/scattergl/plot.js b/src/traces/scattergl/plot.js
@@ -67,7 +67,7 @@ module.exports = function plot(gd, subplot, cdata) {
             scene.line2d = createLine(regl);
         }
         if(scene.scatter2d === true) {
-            scene.scatter2d = createScatter(regl);
+            scene.scatter2d = createScatter(regl, { constPointSize: true });
         }
         if(scene.fill2d === true) {
             scene.fill2d = createLine(regl);
diff --git a/test/image/mocks/gl2d_marker_size.json b/test/image/mocks/gl2d_marker_size.json
@@ -71,5 +71,8 @@
     "height": 400,
     "width": 480,
     "showlegend": false
+  },
+  "config": {
+    "plotGlPixelRatio": 4
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ module.exports = function plot(gd, subplot, cdata) {`
`67`	`67`	`scene.line2d = createLine(regl);`
`68`	`68`	`}`
`69`	`69`	`if(scene.scatter2d === true) {`
`70`		`- scene.scatter2d = createScatter(regl);`
	`70`	`+ scene.scatter2d = createScatter(regl, { constPointSize: true });`
`71`	`71`	`}`
`72`	`72`	`if(scene.fill2d === true) {`
`73`	`73`	`scene.fill2d = createLine(regl);`