AJ-proof latest additions

Author: etpinard

src/plot_api/plot_api.js

@@ -1946,7 +1946,11 @@ function _relayout(gd, aobj) {
 
                 // clear polar view initial stash for radial range so that
                 // value get recomputed in correct units
-                if(Array.isArray(fullLayout._subplots.polar) && fullLayout._subplots.polar.length && fullLayout[p.parts[0]]) {
+                if(Array.isArray(fullLayout._subplots.polar) &&
+                    fullLayout._subplots.polar.length &&
+                    fullLayout[p.parts[0]] &&
+                    p.parts[1] === 'radialaxis'
+                ) {
                     delete fullLayout[p.parts[0]]._subplot.viewInitial['radialaxis.range'];
                 }
 

src/plots/polar/layout_attributes.js

@@ -213,7 +213,7 @@ var angularAxisAttrs = {
         role: 'info',
         description: [
             'Sets that start position (in degrees) of the angular axis',
-            'By default, polar subplots will `direction` set to *counterclockwise*',
+            'By default, polar subplots with `direction` set to *counterclockwise*',
             'get a `rotation` of *0*',
             'which corresponds to due East (like what mathematicians prefer).',
             'In turn, polar with `direction` set to *clockwise* get a rotation of *90*',

test/image/baselines/polar_fills.png

@@ -21,6 +21,14 @@
     "fill": "toself",
     "hoveron": "fills",
     "subplot": "polar2"
+  }, {
+    "type": "scatterpolar",
+    "mode": "markers",
+    "r": [5, 1, 1.5, 4, 5],
+    "theta": [0, 270, 180, 90, 0],
+    "fill": "toself",
+    "hoveron": "fills",
+    "subplot": "polar2"
   }],
   "layout": {
     "polar": {

test/image/mocks/polar_fills.json

@@ -237,18 +237,24 @@ describe('Test relayout on polar subplots:', function() {
         Plotly.plot(gd, fig).then(function() {
             expect(gd._fullLayout.polar._subplot.viewInitial['radialaxis.range'])
                 .toBeCloseToArray([0, 11.225]);
+            expect(gd._fullLayout.polar.radialaxis.range)
+                .toBeCloseToArray([0, 11.225]);
 
             return Plotly.relayout(gd, 'polar.radialaxis.type', 'log');
         })
         .then(function() {
             expect(gd._fullLayout.polar._subplot.viewInitial['radialaxis.range'])
                 .toBeCloseToArray([-0.53, 1.158]);
+            expect(gd._fullLayout.polar.radialaxis.range)
+                .toBeCloseToArray([-0.53, 1.158]);
 
             return Plotly.relayout(gd, 'polar.radialaxis.type', 'linear');
         })
         .then(function() {
             expect(gd._fullLayout.polar._subplot.viewInitial['radialaxis.range'])
                 .toBeCloseToArray([0, 11.225]);
+            expect(gd._fullLayout.polar.radialaxis.range)
+                .toBeCloseToArray([0, 11.225]);
         })
         .catch(fail)
         .then(done);
@@ -570,10 +576,10 @@ describe('Test polar interactions:', function() {
         mouseEvent('mouseout', pos[0], pos[1]);
     }
 
-    function _click(pos) {
+    function _click(pos, opts) {
         eventData = '';
         gd._mouseDownTime = 0;
-        click(pos[0], pos[1]);
+        click(pos[0], pos[1], opts);
     }
 
     function _doubleClick(pos) {
@@ -582,6 +588,24 @@ describe('Test polar interactions:', function() {
         return doubleClick(pos[0], pos[1]);
     }
 
+    var modClickOpts = {
+        altKey: true,
+        ctrlKey: true, // this makes it effectively into a right-click
+        metaKey: true,
+        shiftKey: true,
+        button: 0,
+        cancelContext: true
+    };
+
+    var rightClickOpts = {
+        altKey: false,
+        ctrlKey: false,
+        metaKey: false,
+        shiftKey: false,
+        button: 2,
+        cancelContext: true
+    };
+
     it('should trigger hover/unhover/click/doubleclick events', function(done) {
         var fig = Lib.extendDeep({}, require('@mocks/polar_scatter.json'));
         var ptPos = [250, 200];
@@ -645,6 +669,32 @@ describe('Test polar interactions:', function() {
                 plotly_relayout: 1
             }, 'after doubleclick');
         })
+        .then(function() { _click(ptPos, modClickOpts); })
+        .then(function() {
+            _assert([{
+                r: 3.26,
+                theta: 68.08
+            }], {
+                plotly_hover: 2,
+                plotly_unhover: 1,
+                plotly_click: 4,
+                plotly_doubleclick: 1,
+                plotly_relayout: 1
+            }, 'after modified click');
+        })
+        .then(function() { _click(ptPos, rightClickOpts); })
+        .then(function() {
+            _assert([{
+                r: 3.26,
+                theta: 68.08
+            }], {
+                plotly_hover: 2,
+                plotly_unhover: 1,
+                plotly_click: 5,
+                plotly_doubleclick: 1,
+                plotly_relayout: 1
+            }, 'after right click');
+        })
         .catch(fail)
         .then(done);
     });