Skip to content

Commit 445165b

Browse files
committed
Merge remote-tracking branch 'origin/master' into dev-griddash
2 parents 10e1188 + 13a3773 commit 445165b

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"use-draftlogs": "node tasks/use_draftlogs.js",
3333
"empty-draftlogs": "node tasks/empty_draftlogs.js",
3434
"empty-dist": "node tasks/empty_dist.js",
35-
"build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles basic && npm run extra-bundles cartesian && npm run extra-bundles geo && npm run extra-bundles gl2d && npm run extra-bundles gl3d && npm run extra-bundles mapbox && npm run extra-bundles finance && npm run locales && npm run schema dist && npm run stats",
35+
"build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles && npm run locales && npm run schema dist && npm run stats",
3636
"regl-codegen": "node devtools/regl_codegen/server.js",
3737
"cibuild": "npm run empty-dist && npm run preprocess && node tasks/cibundle.js",
3838
"watch": "node tasks/watch.js",

tasks/bundle.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ tasks.push(function(done) {
3737
standalone: 'Plotly',
3838
pathToMinBundle: pathToPlotlyDistMin
3939
}, function() {
40-
prependFile(pathToPlotlyDist, header, common.throwOnError);
41-
prependFile(pathToPlotlyDistMin, header, common.throwOnError);
40+
prependFile.sync(pathToPlotlyDist, header, common.throwOnError);
41+
prependFile.sync(pathToPlotlyDistMin, header, common.throwOnError);
4242

4343
done();
4444
});
@@ -50,8 +50,8 @@ tasks.push(function(done) {
5050
standalone: 'Plotly',
5151
pathToMinBundle: pathToPlotlyStrictDistMin
5252
}, function() {
53-
prependFile(pathToPlotlyStrictDist, header, common.throwOnError);
54-
prependFile(pathToPlotlyStrictDistMin, header, common.throwOnError);
53+
prependFile.sync(pathToPlotlyStrictDist, header.replace('plotly.js', 'plotly.js (strict)'), common.throwOnError);
54+
prependFile.sync(pathToPlotlyStrictDistMin, header.replace('plotly.js', 'plotly.js (strict - minified)'), common.throwOnError);
5555

5656
done();
5757
});
@@ -62,7 +62,7 @@ tasks.push(function(done) {
6262
_bundle(pathToPlotlyGeoAssetsSrc, pathToPlotlyGeoAssetsDist, {
6363
standalone: 'PlotlyGeoAssets'
6464
}, function() {
65-
prependFile(pathToPlotlyGeoAssetsDist, header, common.throwOnError);
65+
prependFile.sync(pathToPlotlyGeoAssetsDist, header, common.throwOnError);
6666

6767
done();
6868
});
@@ -74,7 +74,7 @@ tasks.push(function(done) {
7474
standalone: 'Plotly',
7575
noCompress: true
7676
}, function() {
77-
prependFile(pathToPlotlyDistWithMeta, header, common.throwOnError);
77+
prependFile.sync(pathToPlotlyDistWithMeta, header, common.throwOnError);
7878

7979
done();
8080
});

tasks/extra_bundles.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ var tasks = [];
3030
for(var i = 0; i < list.length; i++) {
3131
var opts = list[i];
3232

33+
// strict bundle is no longer a partial bundle and generated with bundles
34+
if(opts.name === 'strict') continue;
35+
3336
partialBundle(tasks, {
3437
name: opts.name,
3538
index: opts.index,

tasks/partial_bundle.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ module.exports = function partialBundle(tasks, opts) {
6363
var headerDist = header.replace('plotly.js', 'plotly.js (' + name + ')');
6464
var headerDistMin = header.replace('plotly.js', 'plotly.js (' + name + ' - minified)');
6565

66-
if(dist) prependFile(dist, headerDist, common.throwOnError);
67-
if(distMin) prependFile(distMin, headerDistMin, common.throwOnError);
66+
if(dist) prependFile.sync(dist, headerDist, common.throwOnError);
67+
if(distMin) prependFile.sync(distMin, headerDistMin, common.throwOnError);
6868

6969
done();
7070
});

0 commit comments

Comments
 (0)