Merge branch 'master' into fix0548-surface-contour-all-points

Author: archmoj

.circleci/config.yml

@@ -14,14 +14,10 @@ jobs:
     working_directory: ~/plotly.js
     steps:
       - checkout
-      - restore_cache:
-          keys:
-            - v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-{{ .Branch }}-{{ checksum "package-lock.json" }}
-            - v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-master-{{ checksum "package-lock.json" }}
       - run:
           name: Install dependencies
           command: |
-            npm install
+            npm ci
       - run:
           name: List dependency versions
           command: |
@@ -33,26 +29,21 @@ jobs:
           command: |
             npm run pretest
             npm run cibuild
-      - save_cache:
-          paths:
-            - node_modules
-          key: v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-{{ .Branch }}-{{ checksum "package.json" }}
+      - run:
+          command: rm -rf .git
       - persist_to_workspace:
-          root: .
+          root: /home/circleci
           paths:
-            - node_modules
-            - build
-            - dist
+            - plotly.js
 
   test-jasmine:
     docker:
       # need '-browsers' version to test in real (xvfb-wrapped) browsers
       - image: circleci/node:10.9.0-browsers
     working_directory: ~/plotly.js
     steps:
-      - checkout
       - attach_workspace:
-          at: ~/plotly.js
+          at: ~/
       - run:
           name: Run jasmine tests (batch 1)
           command: ./.circleci/test.sh jasmine
@@ -63,21 +54,31 @@ jobs:
       - image: circleci/node:10.9.0-browsers
     working_directory: ~/plotly.js
     steps:
-      - checkout
       - attach_workspace:
-          at: ~/plotly.js
+          at: ~/
       - run:
           name: Run jasmine tests (batch 2)
           command: ./.circleci/test.sh jasmine2
 
+  test-jasmine3:
+    docker:
+      # need '-browsers' version to test in real (xvfb-wrapped) browsers
+      - image: circleci/node:10.9.0-browsers
+    working_directory: ~/plotly.js
+    steps:
+      - attach_workspace:
+          at: ~/
+      - run:
+          name: Run jasmine tests (batch 3)
+          command: ./.circleci/test.sh jasmine3
+
   test-image:
     docker:
       - image: plotly/testbed:latest
     working_directory: /var/www/streambed/image_server/plotly.js/
     steps:
-      - checkout
       - attach_workspace:
-          at: /var/www/streambed/image_server/plotly.js/
+          at: /var/www/streambed/image_server/
       - run:
           name: Run and setup container
           command: |
@@ -95,9 +96,8 @@ jobs:
       - image: plotly/testbed:latest
     working_directory: /var/www/streambed/image_server/plotly.js/
     steps:
-      - checkout
       - attach_workspace:
-          at: /var/www/streambed/image_server/plotly.js/
+          at: /var/www/streambed/image_server/
       - run:
           name: Run and setup container
           command: |
@@ -115,9 +115,8 @@ jobs:
       - image: circleci/node:10.9.0
     working_directory: ~/plotly.js
     steps:
-      - checkout
       - attach_workspace:
-          at: ~/plotly.js
+          at: ~/
       - run:
           name: Run syntax tests
           command: ./.circleci/test.sh syntax
@@ -127,28 +126,31 @@ jobs:
       - image: circleci/node:10.9.0
     working_directory: ~/plotly.js
     steps:
-      - checkout
       - attach_workspace:
-          at: ~/plotly.js
+          at: ~/
       - run:
-          name: Update plot-schema.json
-          command: node tasks/bundle_plot_schema.js
+          name: Build dist/
+          command: npm run build
       - store_artifacts:
-          path: build/plotly.js
-          destination: /plotly.js
-      - store_artifacts:
-          path: dist/plotly.min.js
-          destination: /plotly.min.js
+          path: dist
+          destination: dist
+      - run:
+          name: Pack tarball
+          command: |
+            npm pack
+            version=$(node -e "console.log(require('./package.json').version)")
+            mv plotly.js-$version.tgz plotly.js.tgz
       - store_artifacts:
-          path: dist/plot-schema.json
-          destination: /plot-schema.json
+          path: plotly.js.tgz
+          destination: /plotly.js.tgz
       - run:
           name: Show URLs to build files
           command: |
             PROJECT_NUM=45646037
-            echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/plotly.js
-            echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/plotly.min.js
-            echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/plot-schema.json
+            echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/plotly.js.tgz
+            echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plotly.js
+            echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plotly.min.js
+            echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plot-schema.json
 
 workflows:
   version: 2
@@ -161,6 +163,9 @@ workflows:
       - test-jasmine2:
           requires:
             - build
+      - test-jasmine3:
+          requires:
+            - build
       - test-image:
           requires:
             - build

.circleci/test.sh

@@ -45,7 +45,6 @@ case $1 in
         set_tz
 
         npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
-        retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
         npm run test-bundle || EXIT_STATE=$?
 
         exit $EXIT_STATE
@@ -63,6 +62,18 @@ case $1 in
         exit $EXIT_STATE
         ;;
 
+    jasmine3)
+        set_tz
+
+        SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))
+
+        for s in ${SHARDS[@]}; do
+            retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
+        done
+
+        exit $EXIT_STATE
+        ;;
+
     image)
         npm run test-image      || EXIT_STATE=$?
         exit $EXIT_STATE

CHANGELOG.md

@@ -10,7 +10,130 @@ https://github.com/plotly/plotly.js/compare/vX.Y.Z...master
 where X.Y.Z is the semver of most recent plotly.js release.
 
 
-## [1.44.4] -- 2019-01-22
+## [1.45.3] -- 2019-03-19
+
+### Fixed
+- Fix legend click dispatch on legend item symbols (bug introduced in 1.44.0) [#3635]
+- Fix overlapping of "very close" hover labels [#3645]
+- Fix `hovermode` default logic for stacked `scatter` traces [#3646]
+- Fix `glPixelRatio` handling in `surface` contour lines [#3641]
+- Fix `gl2d` subplot zoombox appearance (bug introduced in 1.32.0) [#3647]
+- Fix axis label updates on `gl2d` subplots on scroll (bug introduced in 1.32.0) [#3647]
+- Fix `dragmode` relayout calls on `gl2d` subplots [#3647]
+- Improve info about `<extra>` in `hovertemplate` description [#3623]
+
+
+## [1.45.2] -- 2019-03-07
+
+### Fixed
+- Fix webpack builds that include `sankey` by upgrading d3-sankey-circular to 0.33.0 (bug introduced in 1.45.0) [#3611]
+
+## [1.45.1] -- 2019-03-05
+
+### Fixed
+- Fix axis automargin pushes for rotated tick labels [#3605]
+- Fix automargin logic on (very) small graphs [#3605]
+- Fix locales support in `hovertemplate` strings [#3586]
+- Fix gl3d reset camera buttons for scenes with orthographic projection [#3597]
+- Fix typed array support for `parcoords` dimensions values and `line.color` [#3598]
+- Fix `cone` rendering on some older browsers [#3591]
+- Fix `lightposition` behavior for `cone` traces [#3591]
+- Fix `lightposition` behavior for `streamtube` trace [#3593]
+- Remove unused files from `gl-cone3d` dependency [#3591]
+- Remove unused files from `gl-streamtube3d` dependency [#3593]
+
+
+## [1.45.0] -- 2019-02-26
+
+### Added
+- Add support for circular networks in `sankey` traces [#3406, #3535, #3564]
+- Add matching axes behavior to cartesian axes via new axis attribute and
+  new splom attribute dimensions attribute `matches` [#3506, #3565]
+- Add attributes `alignmentgroup` and `offsetgroup` to `bar`, `histogram`, `box`
+  and `violin` traces to make cross-trace positioning easier [#3529]
+- Add support for orthographic projections in gl3d subplots via new attribute
+  `scene.camera.projection.type` [#3550]
+- Add `cmid` and `zmid` colorscale attributes to pick the middle of the color
+  range during the auto-colorscale computations [#3549]
+- Add support for `sankey` grouping via new attribute `groups` [#3556]
+- Add support for `sankey` concentration `colorscales` [#3501]
+- Add support for `hovertemplate` for all `gl3d` traces, `contour`,
+  `heatmap`, `histogram*`, `parcats`, `scattercarpet` and `splom` traces [#3530]
+- Add `hovertext` attribute to all traces that support hover 'text',
+  for consistency with traces that already have an `hovertext` attribute [#3553]
+- Add support for layout `meta` templating in trace `name`,
+  `rangeselector`, `updatemenus` and `sliders` labels as well as
+  within `hovertemplate` [#3548]
+- Add support for `opacity` to `isosurface` traces [#3545]
+- Add `mapbox.layers` attributes: `minzoom`, `maxzoom`, `line.dash` and `symbol.placement` [#3399]
+
+### Changed
+- More consistency pass down WebGL pixel ratio to gl3d renderers,
+  this leads to better axis line and error bar rendering on some hardwares [#3573]
+- Performance boost for `isosurface` trace generation [#3521]
+- Export template string regex of `Lib` [#3548]
+- Do no cluster points in  `scattergl` trace with less than 1e5 data pts,
+  this fixes reported "missing data points" scenarios [#3578]
+
+### Fixed
+- Fix selection outline clearing during cartesian axis-range relayout calls
+  (bug introduced in 1.42.0) [#3577]
+- Fix modebar interactions on graphs with `scatter3d` traces with
+  marker colorscales (bug introduced in 1.44.0) [#3554]
+- Fix axis `automargin` for superimposed subplots (bug introduced in 1.44.3) [#3566]
+- Fix polar angular tick labels placement [#3538]
+- Fix `scattergl` updates after selections for trace with on-graph text [#3575]
+- Fix `responsive: true` config option for graph with WebGL traces [#3500]
+- Fix `modebar.bgcolor` for vertical modebars with wrapped buttons [#3500]
+- Fix `ohlc` and `candlestick` auto-range computations [#3544]
+
+
+## [1.44.4] -- 2019-02-12
+
+### Fixed
+- Fix `Plotly.react` used with `uirevision` when removing traces [#3527]
+- Fix `scattergl` update calls that change the number of on-graph text elements [#3536]
+- Fix annotations SVG errors on trace-less subplots [#3534]
+- Fix `ohlc` and `candlestick` hover on blank coordinates (bug introduced in 1.43.2) [#3537]
+
+
+## [1.44.3] -- 2019-02-06
+
+### Fixed
+- Fix axis `automargin` push offset which resulted in clipped
+  tick labels in some scenarios [#3510]
+- Fix handling of alpha channel in marker, line and error bar `rgba`
+  coloring in `scatter3d` traces [#3496]
+- Fix subplots with multiple `carpet` traces each with a `scattercarpet`
+  trace on top of them [#3512]
+- Fix MathJax placement in ternary `aaxis` titles [#3513]
+
+
+## [1.44.2] -- 2019-02-04
+
+### Fixed
+- Fix vertical modebars in IE11 [@3491]
+- Fix `hovertemplate` for traces with blank `name` [#3480]
+- Fix 3D grid lines and tick labels colored by rgba color
+  with full transparency [#3494]
+- Fix white highlights rendering problems for `mesh3d` trace on
+  some devices (bug introduced in 1.44.0) [#3483]
+- Fix `fill.color` description for `table` traces [#3481]
+
+
+## [1.44.1] -- 2019-01-24
+
+### Fixed
+- Fix `mesh3d` rendering on (some) mobile devices (bug introduced in 1.44.0) [#3463]
+- Fix scene camera update when changing to `turntable` mode when `up.z` is zero
+  (bug introduced in 1.43.0) [#3465, #3475]
+- Fix `react` when cartesian axis `scaleanchor` patterns change [#3461]
+- Fix "days" entries in polish (`pl`) locales [#3464]
+- Remove inner function declarations in our `vectorize-text` that caused
+  bundling errors for some (bug introduced in 1.43.0) [#3474]
+
+
+## [1.44.0] -- 2019-01-22
 
 ### Added
 - Add `isosurface` gl3d trace type [#3438]

build/plotcss.js

@@ -31,16 +31,16 @@ var rules = {
     "X .cursor-n-resize": "cursor:n-resize;",
     "X .cursor-ne-resize": "cursor:ne-resize;",
     "X .cursor-grab": "cursor:-webkit-grab;cursor:grab;",
-    "X .modebar": "position:absolute;top:2px;right:2px;z-index:1001;",
+    "X .modebar": "position:absolute;top:2px;right:2px;",
     "X .ease-bg": "-webkit-transition:background-color 0.3s ease 0s;-moz-transition:background-color 0.3s ease 0s;-ms-transition:background-color 0.3s ease 0s;-o-transition:background-color 0.3s ease 0s;transition:background-color 0.3s ease 0s;",
     "X .modebar--hover>:not(.watermark)": "opacity:0;-webkit-transition:opacity 0.3s ease 0s;-moz-transition:opacity 0.3s ease 0s;-ms-transition:opacity 0.3s ease 0s;-o-transition:opacity 0.3s ease 0s;transition:opacity 0.3s ease 0s;",
     "X:hover .modebar--hover .modebar-group": "opacity:1;",
-    "X .modebar-group": "float:left;display:inline-block;box-sizing:border-box;margin-left:8px;position:relative;vertical-align:middle;white-space:nowrap;",
+    "X .modebar-group": "float:left;display:inline-block;box-sizing:border-box;padding-left:8px;position:relative;vertical-align:middle;white-space:nowrap;",
     "X .modebar-btn": "position:relative;font-size:16px;padding:3px 4px;height:22px;cursor:pointer;line-height:normal;box-sizing:border-box;",
     "X .modebar-btn svg": "position:relative;top:2px;",
     "X .modebar.vertical": "display:flex;flex-direction:column;flex-wrap:wrap;align-content:flex-end;max-height:100%;",
     "X .modebar.vertical svg": "top:-1px;",
-    "X .modebar.vertical .modebar-group": "display:block;float:none;margin-left:0px;margin-bottom:8px;",
+    "X .modebar.vertical .modebar-group": "display:block;float:none;padding-left:0px;padding-bottom:8px;",
     "X .modebar.vertical .modebar-group .modebar-btn": "display:block;text-align:center;",
     "X [data-title]:before,X [data-title]:after": "position:absolute;-webkit-transform:translate3d(0, 0, 0);-moz-transform:translate3d(0, 0, 0);-ms-transform:translate3d(0, 0, 0);-o-transform:translate3d(0, 0, 0);transform:translate3d(0, 0, 0);display:none;opacity:0;z-index:1001;pointer-events:none;top:110%;right:50%;",
     "X [data-title]:hover:before,X [data-title]:hover:after": "display:block;opacity:1;",