fall back for unsupported font-weight values

Author: archmoj

src/plots/font_attributes.js

@@ -20,6 +20,27 @@ module.exports = function(opts) {
     var editType = opts.editType;
     var colorEditType = opts.colorEditType;
     if(colorEditType === undefined) colorEditType = editType;
+
+    var weight = {
+        editType: editType,
+        valType: 'integer',
+        min: 1,
+        max: 1000,
+        extras: ['normal', 'bold'],
+        dflt: 'normal',
+        description: [
+            'Sets the weight (or boldness) of the font.'
+        ].join(' ')
+    };
+
+    if(opts.noNumericWeightValues) {
+        weight.valType = 'enumerated';
+        weight.values = weight.extras;
+        weight.extras = undefined;
+        weight.min = undefined;
+        weight.max = undefined;
+    }
+
     var attrs = {
         family: {
             valType: 'string',
@@ -49,17 +70,7 @@ module.exports = function(opts) {
             editType: colorEditType
         },
 
-        weight: {
-            editType: editType,
-            valType: 'integer',
-            min: 1,
-            max: 1000,
-            extras: ['normal', 'bold'],
-            dflt: 'normal',
-            description: [
-                'Sets the weight (or boldness) of the font.'
-            ].join(' ')
-        },
+        weight: weight,
 
         style: {
             editType: editType,

src/traces/scattergl/attributes.js

@@ -41,6 +41,7 @@ var attrs = module.exports = overrideAll({
         editType: 'calc',
         colorEditType: 'style',
         arrayOk: true,
+        noNumericWeightValues: true,
         variantValues: ['normal', 'small-caps'],
         description: 'Sets the text font.'
     }),

src/traces/scattergl/convert.js

@@ -190,7 +190,7 @@ function convertTextStyle(gd, trace) {
     if(
         isArrayOrTypedArray(tfs) ||
         Array.isArray(tff) ||
-        Array.isArray(tfw) ||
+        Lib.isArrayOrTypedArray(tfw) ||
         Array.isArray(tfy) ||
         Array.isArray(tfv)
     ) {
@@ -207,7 +207,7 @@ function convertTextStyle(gd, trace) {
             ) * plotGlPixelRatio;
 
             fonti.family = Array.isArray(tff) ? tff[i] : tff;
-            fonti.weight = Array.isArray(tfw) ? tfw[i] : tfw;
+            fonti.weight = weightFallBack(Lib.isArrayOrTypedArray(tfw) ? tfw[i] : tfw);
             fonti.style = Array.isArray(tfy) ? tfy[i] : tfy;
             fonti.variant = Array.isArray(tfv) ? tfv[i] : tfv;
         }
@@ -216,7 +216,7 @@ function convertTextStyle(gd, trace) {
         optsOut.font = {
             size: tfs * plotGlPixelRatio,
             family: tff,
-            weight: tfw,
+            weight: weightFallBack(tfw),
             style: tfy,
             variant: tfv
         };
@@ -225,6 +225,12 @@ function convertTextStyle(gd, trace) {
     return optsOut;
 }
 
+function weightFallBack(w) {
+    if(w <= 1000) {
+        return w > 500 ? 'bold' : 'normal';
+    }
+    return w;
+}
 
 function convertMarkerStyle(gd, trace) {
     var count = trace._length;

test/plot-schema.json

@@ -65049,13 +65049,11 @@
       "description": "Sets the weight (or boldness) of the font.",
       "dflt": "normal",
       "editType": "calc",
-      "extras": [
+      "valType": "enumerated",
+      "values": [
        "normal",
        "bold"
-      ],
-      "max": 1000,
-      "min": 1,
-      "valType": "integer"
+      ]
      },
      "weightsrc": {
       "description": "Sets the source reference on Chart Studio Cloud for `weight`.",
@@ -70939,13 +70937,11 @@
       "description": "Sets the weight (or boldness) of the font.",
       "dflt": "normal",
       "editType": "calc",
-      "extras": [
+      "valType": "enumerated",
+      "values": [
        "normal",
        "bold"
-      ],
-      "max": 1000,
-      "min": 1,
-      "valType": "integer"
+      ]
      },
      "weightsrc": {
       "description": "Sets the source reference on Chart Studio Cloud for `weight`.",