Admit isDateTime === true values (e.g. date strings) in non-fancy scattergl

Author: monfera

src/traces/scattergl/convert.js

@@ -114,11 +114,13 @@ proto.handlePick = function(pickResult) {
         index = this.idToIndex[pickResult.pointId];
     }
 
+    var x = this.pickXData[index];
+
     return {
         trace: this,
         dataCoord: pickResult.dataCoord,
         traceCoord: [
-            Number(this.pickXData[index]), // non-fancy scattergl has Dates
+            isNumeric(x) || !Lib.isDateTime(x) ? x : Lib.dateTime2ms(x),
             this.pickYData[index]
         ],
         textLabel: Array.isArray(this.textLabels) ?
@@ -270,7 +272,7 @@ proto.updateFast = function(options) {
         pId = 0,
         ptr = 0;
 
-    var xx, yy;
+    var xx, yy, fastType;
 
     // TODO add 'very fast' mode that bypasses this loop
     // TODO bypass this on modebar +/- zoom
@@ -279,18 +281,24 @@ proto.updateFast = function(options) {
         yy = y[i];
 
         // check for isNaN is faster but doesn't skip over nulls
-        if(!isNumeric(yy)) continue;
-        if(!isNumeric(xx) && !(xx instanceof Date)) continue;
+        fastType = isNumeric(xx) || xx instanceof Date;
 
-        idToIndex[pId++] = i;
+        if(isNumeric(yy) && (fastType || Lib.isDateTime(xx))) {
 
-        positions[ptr++] = xx;
-        positions[ptr++] = yy;
+            if(!fastType) {
+                xx = Lib.dateTime2ms(xx);
+            }
+
+            idToIndex[pId++] = i;
 
-        bounds[0] = Math.min(bounds[0], xx);
-        bounds[1] = Math.min(bounds[1], yy);
-        bounds[2] = Math.max(bounds[2], xx);
-        bounds[3] = Math.max(bounds[3], yy);
+            positions[ptr++] = xx;
+            positions[ptr++] = yy;
+
+            bounds[0] = Math.min(bounds[0], xx);
+            bounds[1] = Math.min(bounds[1], yy);
+            bounds[2] = Math.max(bounds[2], xx);
+            bounds[3] = Math.max(bounds[3], yy);
+        }
     }
 
     positions = truncate(positions, ptr);

test/jasmine/tests/gl2d_date_axis_render_test.js

@@ -81,4 +81,19 @@ describe('date axis', function() {
         expect(gd._fullLayout._plots.xy._scene2d.glplot.objects[3].pointCount).toBe(2);
     });
 
+    it('should use the non-fancy gl-vis/gl-scatter2d with string dates', function() {
+        PlotlyInternal.plot(gd, [{
+            type: 'scattergl',
+            mode: 'markers', // important, as otherwise lines are assumed (which needs fancy)
+            x: ['2016-10-10', '2016-10-11'],
+            y: [15, 16]
+        }]);
+
+        expect(gd._fullLayout.xaxis.type).toBe('date');
+        expect(gd._fullLayout.yaxis.type).toBe('linear');
+        expect(gd._fullData[0].type).toBe('scattergl');
+        expect(gd._fullData[0]._module.basePlotModule.name).toBe('gl2d');
+
+        expect(gd._fullLayout._plots.xy._scene2d.glplot.objects[3].pointCount).toBe(2);
+    });
 });