Skip to content

Commit 3a812c9

Browse files
committed
make getUpdateObject use ax._name to build update object
1 parent b2988b4 commit 3a812c9

File tree

2 files changed

+30
-13
lines changed

2 files changed

+30
-13
lines changed

src/components/rangeselector/get_update_object.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,17 @@ var d3 = require('d3');
1313

1414

1515
module.exports = function getUpdateObject(axisLayout, buttonLayout) {
16-
var update;
16+
var axName = axisLayout._name;
17+
var update = {};
1718

1819
if(buttonLayout.step === 'all') {
19-
update = {
20-
'xaxis.autorange': true
21-
};
20+
update[axName + '.autorange'] = true;
2221
}
2322
else {
2423
var xrange = getXRange(axisLayout, buttonLayout);
2524

26-
update = {
27-
'xaxis.range[0]': xrange[0],
28-
'xaxis.range[1]': xrange[1]
29-
};
25+
update[axName + '.range[0]'] = xrange[0];
26+
update[axName + '.range[1]'] = xrange[1];
3027
}
3128

3229
return update;

test/jasmine/tests/range_selector_test.js

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ describe('[range selector suite]', function() {
9292

9393
describe('getUpdateObject:', function() {
9494
var axisLayout = {
95+
_name: 'xaxis',
9596
range: [
9697
(new Date(1948, 0, 1)).getTime(),
9798
(new Date(2015, 10, 30)).getTime()
@@ -194,10 +195,7 @@ describe('[range selector suite]', function() {
194195

195196
var update = getUpdateObject(axisLayout, buttonLayout);
196197

197-
expect(update).toEqual({
198-
'xaxis.autorange': true,
199-
'xaxis.range': null
200-
});
198+
expect(update).toEqual({ 'xaxis.autorange': true });
201199
});
202200

203201
it('should return update object (10 day backward case)', function() {
@@ -277,7 +275,6 @@ describe('[range selector suite]', function() {
277275
});
278276

279277
it('should return update object (2 second to-date case)', function() {
280-
281278
var buttonLayout = {
282279
step: 'second',
283280
stepmode: 'to date',
@@ -291,6 +288,29 @@ describe('[range selector suite]', function() {
291288
assertRanges(update, new Date(2015, 10, 30, 12, 20, 1), new Date(2015, 10, 30, 12, 20, 2));
292289
});
293290

291+
it('should return update object with correct axis names', function() {
292+
var axisLayout = {
293+
_name: 'xaxis5',
294+
range: [
295+
(new Date(1948, 0, 1)).getTime(),
296+
(new Date(2015, 10, 30)).getTime()
297+
]
298+
};
299+
300+
var buttonLayout = {
301+
step: 'month',
302+
stepmode: 'backward',
303+
count: 1
304+
}
305+
306+
var update = getUpdateObject(axisLayout, buttonLayout)
307+
308+
expect(update).toEqual({
309+
'xaxis5.range[0]': new Date(2015, 9, 30).getTime(),
310+
'xaxis5.range[1]': new Date(2015, 10, 30).getTime()
311+
});
312+
313+
});
294314
});
295315

296316
describe('interactions:', function() {

0 commit comments

Comments
 (0)