keep quotes in the case of base url

Author: archmoj

src/components/drawing/index.js

@@ -1270,7 +1270,9 @@ function getFullUrl(localId, gd) {
 
     var context = gd._context;
     var baseUrl = context._exportedPlot ? '' : (context._baseUrl || '');
-    return 'url(' + baseUrl + '#' + localId + ')';
+    return baseUrl ?
+        'url(\'' + baseUrl + '#' + localId + '\')' :
+        'url(#' + localId + ')';
 }
 
 drawing.getTranslate = function(element) {

test/jasmine/tests/drawing_test.js

@@ -29,7 +29,7 @@ describe('Drawing', function() {
         });
 
         it('should unset the clip-path if arg is falsy', function() {
-            this.g.attr('clip-path', 'url(#id2)');
+            this.g.attr('clip-path', 'url(\'#id2\')');
 
             Drawing.setClipUrl(this.g, false);
 
@@ -48,7 +48,7 @@ describe('Drawing', function() {
             Drawing.setClipUrl(this.g, 'id3', {_context: {_baseUrl: href}});
 
             expect(this.g.attr('clip-path'))
-                .toEqual('url(' + href + '#id3)');
+                .toEqual('url(\'' + href + '#id3\')');
 
             base.remove();
         });
@@ -64,7 +64,7 @@ describe('Drawing', function() {
 
             Drawing.setClipUrl(this.g, 'id4', {_context: {_baseUrl: href2}});
 
-            var expected = 'url(' + href2 + '#id4)';
+            var expected = 'url(\'' + href2 + '#id4\')';
 
             expect(this.g.attr('clip-path')).toEqual(expected);
 

test/jasmine/tests/plot_interact_test.js

@@ -568,8 +568,8 @@ describe('plot svg clip paths', function() {
             d3SelectAll('[clip-path]').each(function() {
                 var cp = d3Select(this).attr('clip-path');
 
-                expect(cp.substring(0, 5 + href.length)).toEqual('url(' + href + '#');
-                expect(cp.substring(cp.length - 1)).toEqual(')');
+                expect(cp.substring(0, 6 + href.length)).toEqual('url(\'' + href + '#');
+                expect(cp.substring(cp.length - 2)).toEqual('\')');
             });
 
             base.remove();

test/jasmine/tests/snapshot_test.js

@@ -251,7 +251,7 @@ describe('Plotly.Snapshot', function() {
 
         describe('should handle quoted style properties', function() {
             function checkURL(actual, msg) {
-                // which is enough to check that toSVG did its job right
+                // which is enough tot check that toSVG did its job right
                 expect((actual || '').substr(0, 6)).toBe('url(\"#', msg);
             }