Merge pull request #4439 from plotly/histogram-bingroup-wo-calendars

Fix histogram bingroup algo when calendars module is not registered

Author: etpinard

src/traces/histogram/cross_trace_defaults.js

@@ -55,7 +55,7 @@ module.exports = function crossTraceDefaults(fullData, fullLayout) {
         if(!groupName) groupName = fallbackGroupName;
 
         var axType = getAxisType(traceOut, binDir);
-        var calendar = traceOut[binDir + 'calendar'];
+        var calendar = traceOut[binDir + 'calendar'] || '';
         var binOpts = allBinOpts[groupName];
         var needsNewItem = true;
 

test/jasmine/tests/histogram_test.js

@@ -1,6 +1,7 @@
 var Plotly = require('@lib/index');
 var Plots = require('@src/plots/plots');
 var Lib = require('@src/lib');
+var Registry = require('@src/registry');
 var setConvert = require('@src/plots/cartesian/set_convert');
 
 var supplyDefaults = require('@src/traces/histogram/defaults');
@@ -478,6 +479,35 @@ describe('Test histogram', function() {
             );
         });
 
+        it('should attempt to group traces when the *calendars* module is not registered', function() {
+            var original = Registry.getComponentMethod;
+            var cnt = 0;
+
+            spyOn(Registry, 'getComponentMethod').and.callFake(function() {
+                if(arguments[0] === 'calendars') {
+                    cnt++;
+                    return Lib.noop;
+                } else {
+                    return original.call(arguments);
+                }
+            });
+
+            gd = {
+                data: [
+                    {uid: 'a', type: 'histogram', x: [1, 3]},
+                    {uid: 'b', type: 'histogram', x: [1, 20]}
+                ],
+                layout: {barmode: 'stack'}
+            };
+            supplyAllDefaults(gd);
+
+            _assert('', [
+                ['xyx', [0, 1]]
+            ]);
+
+            expect(cnt).toBe(3, '# of Registry.getComponentMethod calls for *calendars* methods');
+        });
+
         it('should force traces that "have to match" to have same bingroup (alignmentgroup case)', function() {
             var traces;