use scope variable instead of fullLayout private key

... to avoid infinite drawFramework loops

Author: etpinard

src/plot_api/plot_api.js

@@ -199,6 +199,7 @@ exports.plot = function(gd, data, layout, config) {
 
     // draw framework first so that margin-pushing
     // components can position themselves correctly
+    var drawFrameworkCalls = 0;
     function drawFramework() {
         var basePlotModules = fullLayout._basePlotModules;
 
@@ -251,15 +252,15 @@ exports.plot = function(gd, data, layout, config) {
                     fullLayout.height !== regl._gl.drawingBufferHeight
                  ) {
                     var msg = 'WebGL context buffer and canvas dimensions do not match due to browser/WebGL bug.';
-                    if(fullLayout._redrawFromWrongGlDimensions) {
+                    if(drawFrameworkCalls) {
                         Lib.error(msg);
                     } else {
                         Lib.log(msg + ' Clearing graph and plotting again.');
                         Plots.cleanPlot([], {}, gd._fullData, fullLayout, gd.calcdata);
                         Plots.supplyDefaults(gd);
                         fullLayout = gd._fullLayout;
                         Plots.doCalcdata(gd);
-                        fullLayout._redrawFromWrongGlDimensions = 1;
+                        drawFrameworkCalls++;
                         return drawFramework();
                     }
                 }

test/jasmine/tests/splom_test.js

@@ -717,7 +717,6 @@ describe('Test splom interactions:', function() {
             });
             assertDims('base', 600, 500);
             expect(Lib.log).toHaveBeenCalledTimes(0);
-            expect(gd._fullLayout._redrawFromWrongGlDimensions).toBeUndefined();
 
             spyOn(gd._fullData[0]._module, 'plot').and.callThrough();
 
@@ -732,7 +731,6 @@ describe('Test splom interactions:', function() {
             assertDims('after', 4810, 3656);
             expect(Lib.log)
                 .toHaveBeenCalledWith('WebGL context buffer and canvas dimensions do not match due to browser/WebGL bug. Clearing graph and plotting again.');
-            expect(gd._fullLayout._redrawFromWrongGlDimensions).toBe(1);
         })
         .catch(failTest)
         .then(done);