Skip to content

Commit 361d8b5

Browse files
authored
Merge pull request #7574 from plotly/fix-7559-legend-visible
Fix issue where `visible` property of one legend was affecting another
2 parents 49898bc + 0de2980 commit 361d8b5

File tree

2 files changed

+794
-653
lines changed

2 files changed

+794
-653
lines changed

src/components/legend/defaults.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,11 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {
3333
};
3434

3535
var globalFont = layoutOut.font || {};
36-
var grouptitlefont = Lib.coerceFont(coerce, 'grouptitlefont', globalFont, { overrideDflt: {
37-
size: Math.round(globalFont.size * 1.1)
38-
}});
36+
var grouptitlefont = Lib.coerceFont(coerce, 'grouptitlefont', globalFont, {
37+
overrideDflt: {
38+
size: Math.round(globalFont.size * 1.1)
39+
}
40+
});
3941

4042
var legendTraceCount = 0;
4143
var legendReallyHasATrace = false;
@@ -82,13 +84,13 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {
8284
}
8385

8486
if((!isShape && Registry.traceIs(trace, 'bar') && layoutOut.barmode === 'stack') ||
85-
['tonextx', 'tonexty'].indexOf(trace.fill) !== -1) {
86-
defaultOrder = helpers.isGrouped({traceorder: defaultOrder}) ?
87+
['tonextx', 'tonexty'].indexOf(trace.fill) !== -1) {
88+
defaultOrder = helpers.isGrouped({ traceorder: defaultOrder }) ?
8789
'grouped+reversed' : 'reversed';
8890
}
8991

9092
if(trace.legendgroup !== undefined && trace.legendgroup !== '') {
91-
defaultOrder = helpers.isReversed({traceorder: defaultOrder}) ?
93+
defaultOrder = helpers.isReversed({ traceorder: defaultOrder }) ?
9294
'reversed+grouped' : 'grouped';
9395
}
9496
}
@@ -237,10 +239,7 @@ module.exports = function legendDefaults(layoutIn, layoutOut, fullData) {
237239

238240
groupDefaults(legendId, layoutIn, layoutOut, allLegendsData);
239241

240-
if(
241-
layoutOut[legendId] &&
242-
layoutOut[legendId].visible
243-
) {
242+
if(layoutOut[legendId]) {
244243
layoutOut[legendId]._id = legendId;
245244
}
246245

0 commit comments

Comments
 (0)