fix #3058 - prune-out base attrs based on module categories

... during Plotly.PlotSchema.get()

Author: etpinard

src/plot_api/plot_schema.js

@@ -453,8 +453,7 @@ function getTraceAttributes(type) {
     if(type === 'area') {
         _module = { attributes: polarAreaAttrs };
         basePlotModule = {};
-    }
-    else {
+    } else {
         _module = Registry.modules[type]._module,
         basePlotModule = _module.basePlotModule;
     }
@@ -464,7 +463,6 @@ function getTraceAttributes(type) {
     // make 'type' the first attribute in the object
     attributes.type = null;
 
-
     var copyBaseAttributes = extendDeepAll({}, baseAttributes);
     var copyModuleAttributes = extendDeepAll({}, _module.attributes);
 
@@ -478,6 +476,22 @@ function getTraceAttributes(type) {
     // base attributes (same for all trace types)
     extendDeepAll(attributes, copyBaseAttributes);
 
+    // prune-out base attributes based on trace module categories
+    if(Registry.traceIs(type, 'noOpacity')) {
+        delete attributes.opacity;
+    }
+    if(!Registry.traceIs(type, 'showLegend')) {
+        delete attributes.showlegend;
+        delete attributes.legendgroup;
+    }
+    if(Registry.traceIs(type, 'noHover')) {
+        delete attributes.hoverinfo;
+        delete attributes.hoverlabel;
+    }
+    if(!_module.selectPoints) {
+        delete attributes.selectedpoints;
+    }
+
     // module attributes
     extendDeepAll(attributes, copyModuleAttributes);
 

test/jasmine/bundle_tests/plotschema_test.js

@@ -368,7 +368,13 @@ describe('plot schema', function() {
     });
 
     it('should prune unsupported global-level trace attributes', function() {
-        expect(Plotly.PlotSchema.get().traces.sankey.attributes.hoverinfo.flags.length).toBe(0);
+        var traces = Plotly.PlotSchema.get().traces;
+
+        expect(traces.sankey.attributes.hoverinfo.flags.length).toBe(0);
+        expect(traces.choropleth.attributes.showlegend).toBe(undefined, 'no legend attrs for choropleth (for now)');
+        expect(traces.table.attributes.opacity).toBe(undefined, 'no opacity attr for table');
+        expect(traces.parcoords.attributes.hoverinfo).toBe(undefined, 'no hover attrs for parcoords');
+        expect(traces.scatter3d.attributes.selectedpoints).toBe(undefined, 'no selectedpoints for gl3d traces');
     });
 });