lint -> function() not function ()

Author: etpinard

devtools/image_viewer/viewer.js

@@ -37,7 +37,7 @@ function createButton(imageName) {
     button.style.height = '40px';
     button.innerHTML = imageName;
 
-    button.addEventListener('click', function () {
+    button.addEventListener('click', function() {
         var imgBaseline = createImg(dirBaseline, imageName),
             imgTest = createImg(dirTest, imageName),
             imgDiff = createImg(dirDiff, 'diff-' + imageName);

devtools/test_dashboard/buttons.js

@@ -13,7 +13,7 @@ anchor.style.width = '1000px';
 
 function plotButtons(plots, figDir) {
 
-    Object.keys(plots).forEach(function (plotname) {
+    Object.keys(plots).forEach(function(plotname) {
 
         var button = document.createElement('button');
 
@@ -25,7 +25,7 @@ function plotButtons(plots, figDir) {
 
         plotlist.appendChild(button);
 
-        button.addEventListener('click', function () {
+        button.addEventListener('click', function() {
 
             var myImage = new Image();
             myImage.src = figDir + plotname + '.png';
@@ -90,7 +90,7 @@ function plotButtons(plots, figDir) {
                 var myImage = new Image();
                 myImage.src = dataURL;
 
-                myImage.onload = function () {
+                myImage.onload = function() {
                     myImage.height = scene.container.clientHeight;
                     myImage.width = scene.container.clientWidth;
                 };
@@ -114,17 +114,17 @@ function plotButtons(plots, figDir) {
     var mock = require('@mocks/gl3d_marker-color.json');
     var statusDiv = document.getElementById('status-info');
 
-    pummelButton.addEventListener('click', function () {
-        setInterval(function () {
+    pummelButton.addEventListener('click', function() {
+        setInterval(function() {
             var plotDiv = document.createElement('div');
             window.plotDiv = plotDiv;
 
             plotDiv.id = 'div' + i;
             document.body.appendChild(plotDiv);
 
-            Plotly.plot(plotDiv, mock.data, mock.layout, {staticPlot: true}).then(function () {
+            Plotly.plot(plotDiv, mock.data, mock.layout, {staticPlot: true}).then(function() {
 
-                Plotly.Plots.getSubplotIds(plotDiv._fullLayout, 'gl3d').forEach(function (key) {
+                Plotly.Plots.getSubplotIds(plotDiv._fullLayout, 'gl3d').forEach(function(key) {
                     var scene = plotDiv._fullLayout[key]._scene;
                     scene.destroy();
                     i ++;
@@ -146,7 +146,7 @@ function plotButtons(plots, figDir) {
     scrapeButton.style.background = 'blue';
     plotlist.appendChild(scrapeButton);
 
-    scrapeButton.addEventListener('click', function () {
+    scrapeButton.addEventListener('click', function() {
         Plotly.Snapshot.toSVG(Tabs.get());
         return;
     });

src/components/colorbar/draw.js

@@ -500,7 +500,7 @@ module.exports = function draw(gd, id) {
     }
 
     // setter/getters for every item defined in opts
-    Object.keys(opts).forEach(function (name) {
+    Object.keys(opts).forEach(function(name) {
         component[name] = function(v) {
             // getter
             if(!arguments.length) return opts[name];

src/components/errorbars/defaults.js

@@ -21,7 +21,7 @@ module.exports = function(traceIn, traceOut, defaultColor, opts) {
         containerOut = traceOut[objName] = {},
         containerIn = traceIn[objName] || {};
 
-    function coerce (attr, dflt) {
+    function coerce(attr, dflt) {
         return Lib.coerce(containerIn, containerOut, attributes, attr, dflt);
     }
 

src/components/modebar/buttons.js

@@ -83,7 +83,7 @@ modeBarButtons.toImage = {
             ev.clean();
         });
 
-        ev.once('error', function (err) {
+        ev.once('error', function(err) {
             gd._snapshotInProgress = false;
 
             Lib.notifier('Sorry there was a problem downloading your ' + format, 'long');

src/components/modebar/index.js

@@ -102,7 +102,7 @@ proto.updateButtons = function(buttons) {
  * Empty div for containing a group of buttons
  * @Return {HTMLelement}
  */
-proto.createGroup = function () {
+proto.createGroup = function() {
     var group = document.createElement('div');
     group.className = 'modebar-group';
 
@@ -114,7 +114,7 @@ proto.createGroup = function () {
  * @Param {object} config (see ./buttons.js for more info)
  * @Return {HTMLelement}
  */
-proto.createButton = function (config) {
+proto.createButton = function(config) {
     var _this = this,
         button = document.createElement('a');
 
@@ -162,7 +162,7 @@ proto.createButton = function (config) {
  * @Param {string} thisIcon.path
  * @Return {HTMLelement}
  */
-proto.createIcon = function (thisIcon) {
+proto.createIcon = function(thisIcon) {
     var iconHeight = thisIcon.ascent - thisIcon.descent,
         svgNS = 'http://www.w3.org/2000/svg',
         icon = document.createElementNS(svgNS, 'svg'),
@@ -216,7 +216,7 @@ proto.updateActiveButton = function(buttonClicked) {
  * @Param {object} buttons 2d array of grouped button config objects
  * @Return {boolean}
  */
-proto.hasButtons = function (buttons) {
+proto.hasButtons = function(buttons) {
     var currentButtons = this.buttons;
 
     if(!currentButtons) return false;

src/lib/index.js

@@ -303,7 +303,7 @@ lib.syncOrAsync = function(sequence, arg, finalStep) {
  * Helper to strip trailing slash, from
  * http://stackoverflow.com/questions/6680825/return-string-without-trailing-slash
  */
-lib.stripTrailingSlash = function (str) {
+lib.stripTrailingSlash = function(str) {
     if (str.substr(-1) === '/') return str.substr(0, str.length - 1);
     return str;
 };

src/lib/matrix.js

@@ -67,12 +67,12 @@ exports.dot = function(x, y) {
 };
 
 // translate by (x,y)
-exports.translationMatrix = function (x, y) {
+exports.translationMatrix = function(x, y) {
     return [[1, 0, x], [0, 1, y], [0, 0, 1]];
 };
 
 // rotate by alpha around (0,0)
-exports.rotationMatrix = function (alpha) {
+exports.rotationMatrix = function(alpha) {
     var a = alpha*Math.PI/180;
     return [[Math.cos(a), -Math.sin(a), 0],
             [Math.sin(a), Math.cos(a), 0],

src/lib/queue.js

@@ -18,7 +18,7 @@ var Plotly = require('../plotly');
  * @param args
  * @returns {Array}
  */
-function copyArgArray (gd, args) {
+function copyArgArray(gd, args) {
     var copy = [];
     var arg;
 
@@ -188,7 +188,7 @@ queue.redo = function redo(gd) {
  * @param func
  * @param args
  */
-queue.plotDo = function (gd, func, args) {
+queue.plotDo = function(gd, func, args) {
     gd.autoplay = true;
 
     // this *won't* copy gd and it preserves `undefined` properties!

src/lib/show_no_webgl_msg.js

@@ -11,6 +11,9 @@
 
 var Plotly = require('../plotly');
 
+var noop = function() {};
+
+
 /**
  * Prints a no webgl error message into the scene container
  * @param {scene instance} scene
@@ -19,13 +22,11 @@ var Plotly = require('../plotly');
  *
  */
 module.exports = function showWebGlMsg(scene) {
-    var noop = function () {};
-
     for(var prop in scene) {
         if (typeof scene[prop] === 'function') scene[prop] = noop;
     }
 
-    scene.destroy = function () {
+    scene.destroy = function() {
         scene.container.parentNode.removeChild(scene.container);
     };
 
@@ -37,7 +38,7 @@ module.exports = function showWebGlMsg(scene) {
 
     scene.container.appendChild(div);
     scene.container.style.background = '#FFFFFF';
-    scene.container.onclick = function () {
+    scene.container.onclick = function() {
         window.open('http://get.webgl.org');
     };