Skip to content

Commit 2d801b4

Browse files
archmojarchmoj
authored
Merge pull request #5425 from plotly/remove-role
Drop role key from attributes
2 parents 5f51450 + bd47920 commit 2d801b4

File tree

101 files changed

+10
-1073
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+10
-1073
lines changed

‎src/components/annotations/attributes.js‎

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ function arrowCoordinateDescription(axis, lower, upper) {
4444
module.exports = templatedArray('annotation', {
4545
visible: {
4646
valType: 'boolean',
47-
role: 'info',
4847
dflt: true,
4948
editType: 'calc+arraydraw',
5049
description: [
@@ -54,7 +53,6 @@ module.exports = templatedArray('annotation', {
5453

5554
text: {
5655
valType: 'string',
57-
role: 'info',
5856
editType: 'calc+arraydraw',
5957
description: [
6058
'Sets the text associated with this annotation.',
@@ -67,7 +65,6 @@ module.exports = templatedArray('annotation', {
6765
textangle: {
6866
valType: 'angle',
6967
dflt: 0,
70-
role: 'style',
7168
editType: 'calc+arraydraw',
7269
description: [
7370
'Sets the angle at which the `text` is drawn',
@@ -83,7 +80,6 @@ module.exports = templatedArray('annotation', {
8380
valType: 'number',
8481
min: 1,
8582
dflt: null,
86-
role: 'style',
8783
editType: 'calc+arraydraw',
8884
description: [
8985
'Sets an explicit width for the text box. null (default) lets the',
@@ -95,7 +91,6 @@ module.exports = templatedArray('annotation', {
9591
valType: 'number',
9692
min: 1,
9793
dflt: null,
98-
role: 'style',
9994
editType: 'calc+arraydraw',
10095
description: [
10196
'Sets an explicit height for the text box. null (default) lets the',
@@ -107,15 +102,13 @@ module.exports = templatedArray('annotation', {
107102
min: 0,
108103
max: 1,
109104
dflt: 1,
110-
role: 'style',
111105
editType: 'arraydraw',
112106
description: 'Sets the opacity of the annotation (text + arrow).'
113107
},
114108
align: {
115109
valType: 'enumerated',
116110
values: ['left', 'center', 'right'],
117111
dflt: 'center',
118-
role: 'style',
119112
editType: 'arraydraw',
120113
description: [
121114
'Sets the horizontal alignment of the `text` within the box.',
@@ -128,7 +121,6 @@ module.exports = templatedArray('annotation', {
128121
valType: 'enumerated',
129122
values: ['top', 'middle', 'bottom'],
130123
dflt: 'middle',
131-
role: 'style',
132124
editType: 'arraydraw',
133125
description: [
134126
'Sets the vertical alignment of the `text` within the box.',
@@ -139,14 +131,12 @@ module.exports = templatedArray('annotation', {
139131
bgcolor: {
140132
valType: 'color',
141133
dflt: 'rgba(0,0,0,0)',
142-
role: 'style',
143134
editType: 'arraydraw',
144135
description: 'Sets the background color of the annotation.'
145136
},
146137
bordercolor: {
147138
valType: 'color',
148139
dflt: 'rgba(0,0,0,0)',
149-
role: 'style',
150140
editType: 'arraydraw',
151141
description: [
152142
'Sets the color of the border enclosing the annotation `text`.'
@@ -156,7 +146,6 @@ module.exports = templatedArray('annotation', {
156146
valType: 'number',
157147
min: 0,
158148
dflt: 1,
159-
role: 'style',
160149
editType: 'calc+arraydraw',
161150
description: [
162151
'Sets the padding (in px) between the `text`',
@@ -167,7 +156,6 @@ module.exports = templatedArray('annotation', {
167156
valType: 'number',
168157
min: 0,
169158
dflt: 1,
170-
role: 'style',
171159
editType: 'calc+arraydraw',
172160
description: [
173161
'Sets the width (in px) of the border enclosing',
@@ -178,7 +166,6 @@ module.exports = templatedArray('annotation', {
178166
showarrow: {
179167
valType: 'boolean',
180168
dflt: true,
181-
role: 'style',
182169
editType: 'calc+arraydraw',
183170
description: [
184171
'Determines whether or not the annotation is drawn with an arrow.',
@@ -188,7 +175,6 @@ module.exports = templatedArray('annotation', {
188175
},
189176
arrowcolor: {
190177
valType: 'color',
191-
role: 'style',
192178
editType: 'arraydraw',
193179
description: 'Sets the color of the annotation arrow.'
194180
},
@@ -197,7 +183,6 @@ module.exports = templatedArray('annotation', {
197183
min: 0,
198184
max: ARROWPATHS.length,
199185
dflt: 1,
200-
role: 'style',
201186
editType: 'arraydraw',
202187
description: 'Sets the end annotation arrow head style.'
203188
},
@@ -206,7 +191,6 @@ module.exports = templatedArray('annotation', {
206191
min: 0,
207192
max: ARROWPATHS.length,
208193
dflt: 1,
209-
role: 'style',
210194
editType: 'arraydraw',
211195
description: 'Sets the start annotation arrow head style.'
212196
},
@@ -215,15 +199,13 @@ module.exports = templatedArray('annotation', {
215199
flags: ['end', 'start'],
216200
extras: ['none'],
217201
dflt: 'end',
218-
role: 'style',
219202
editType: 'arraydraw',
220203
description: 'Sets the annotation arrow head position.'
221204
},
222205
arrowsize: {
223206
valType: 'number',
224207
min: 0.3,
225208
dflt: 1,
226-
role: 'style',
227209
editType: 'calc+arraydraw',
228210
description: [
229211
'Sets the size of the end annotation arrow head, relative to `arrowwidth`.',
@@ -234,7 +216,6 @@ module.exports = templatedArray('annotation', {
234216
valType: 'number',
235217
min: 0.3,
236218
dflt: 1,
237-
role: 'style',
238219
editType: 'calc+arraydraw',
239220
description: [
240221
'Sets the size of the start annotation arrow head, relative to `arrowwidth`.',
@@ -244,15 +225,13 @@ module.exports = templatedArray('annotation', {
244225
arrowwidth: {
245226
valType: 'number',
246227
min: 0.1,
247-
role: 'style',
248228
editType: 'calc+arraydraw',
249229
description: 'Sets the width (in px) of annotation arrow line.'
250230
},
251231
standoff: {
252232
valType: 'number',
253233
min: 0,
254234
dflt: 0,
255-
role: 'style',
256235
editType: 'calc+arraydraw',
257236
description: [
258237
'Sets a distance, in pixels, to move the end arrowhead away from the',
@@ -266,7 +245,6 @@ module.exports = templatedArray('annotation', {
266245
valType: 'number',
267246
min: 0,
268247
dflt: 0,
269-
role: 'style',
270248
editType: 'calc+arraydraw',
271249
description: [
272250
'Sets a distance, in pixels, to move the start arrowhead away from the',
@@ -278,15 +256,13 @@ module.exports = templatedArray('annotation', {
278256
},
279257
ax: {
280258
valType: 'any',
281-
role: 'info',
282259
editType: 'calc+arraydraw',
283260
description: [
284261
arrowCoordinateDescription('x', 'left', 'right')
285262
].join(' ')
286263
},
287264
ay: {
288265
valType: 'any',
289-
role: 'info',
290266
editType: 'calc+arraydraw',
291267
description: [
292268
arrowCoordinateDescription('y', 'top', 'bottom')
@@ -299,7 +275,6 @@ module.exports = templatedArray('annotation', {
299275
'pixel',
300276
cartesianConstants.idRegex.x.toString()
301277
],
302-
role: 'info',
303278
editType: 'calc',
304279
description: [
305280
'Indicates in what coordinates the tail of the',
@@ -315,7 +290,6 @@ module.exports = templatedArray('annotation', {
315290
'pixel',
316291
cartesianConstants.idRegex.y.toString()
317292
],
318-
role: 'info',
319293
editType: 'calc',
320294
description: [
321295
'Indicates in what coordinates the tail of the',
@@ -331,7 +305,6 @@ module.exports = templatedArray('annotation', {
331305
'paper',
332306
cartesianConstants.idRegex.x.toString()
333307
],
334-
role: 'info',
335308
editType: 'calc',
336309
description: [
337310
'Sets the annotation\'s x coordinate axis.',
@@ -340,7 +313,6 @@ module.exports = templatedArray('annotation', {
340313
},
341314
x: {
342315
valType: 'any',
343-
role: 'info',
344316
editType: 'calc+arraydraw',
345317
description: [
346318
'Sets the annotation\'s x position.',
@@ -358,7 +330,6 @@ module.exports = templatedArray('annotation', {
358330
valType: 'enumerated',
359331
values: ['auto', 'left', 'center', 'right'],
360332
dflt: 'auto',
361-
role: 'info',
362333
editType: 'calc+arraydraw',
363334
description: [
364335
'Sets the text box\'s horizontal position anchor',
@@ -377,7 +348,6 @@ module.exports = templatedArray('annotation', {
377348
xshift: {
378349
valType: 'number',
379350
dflt: 0,
380-
role: 'style',
381351
editType: 'calc+arraydraw',
382352
description: [
383353
'Shifts the position of the whole annotation and arrow to the',
@@ -390,7 +360,6 @@ module.exports = templatedArray('annotation', {
390360
'paper',
391361
cartesianConstants.idRegex.y.toString()
392362
],
393-
role: 'info',
394363
editType: 'calc',
395364
description: [
396365
'Sets the annotation\'s y coordinate axis.',
@@ -399,7 +368,6 @@ module.exports = templatedArray('annotation', {
399368
},
400369
y: {
401370
valType: 'any',
402-
role: 'info',
403371
editType: 'calc+arraydraw',
404372
description: [
405373
'Sets the annotation\'s y position.',
@@ -417,7 +385,6 @@ module.exports = templatedArray('annotation', {
417385
valType: 'enumerated',
418386
values: ['auto', 'top', 'middle', 'bottom'],
419387
dflt: 'auto',
420-
role: 'info',
421388
editType: 'calc+arraydraw',
422389
description: [
423390
'Sets the text box\'s vertical position anchor',
@@ -436,7 +403,6 @@ module.exports = templatedArray('annotation', {
436403
yshift: {
437404
valType: 'number',
438405
dflt: 0,
439-
role: 'style',
440406
editType: 'calc+arraydraw',
441407
description: [
442408
'Shifts the position of the whole annotation and arrow up',
@@ -447,7 +413,6 @@ module.exports = templatedArray('annotation', {
447413
valType: 'enumerated',
448414
values: [false, 'onoff', 'onout'],
449415
dflt: false,
450-
role: 'style',
451416
editType: 'arraydraw',
452417
description: [
453418
'Makes this annotation respond to clicks on the plot.',
@@ -466,7 +431,6 @@ module.exports = templatedArray('annotation', {
466431
},
467432
xclick: {
468433
valType: 'any',
469-
role: 'info',
470434
editType: 'arraydraw',
471435
description: [
472436
'Toggle this annotation when clicking a data point whose `x` value',
@@ -475,7 +439,6 @@ module.exports = templatedArray('annotation', {
475439
},
476440
yclick: {
477441
valType: 'any',
478-
role: 'info',
479442
editType: 'arraydraw',
480443
description: [
481444
'Toggle this annotation when clicking a data point whose `y` value',
@@ -484,7 +447,6 @@ module.exports = templatedArray('annotation', {
484447
},
485448
hovertext: {
486449
valType: 'string',
487-
role: 'info',
488450
editType: 'arraydraw',
489451
description: [
490452
'Sets text to appear when hovering over this annotation.',
@@ -494,7 +456,6 @@ module.exports = templatedArray('annotation', {
494456
hoverlabel: {
495457
bgcolor: {
496458
valType: 'color',
497-
role: 'style',
498459
editType: 'arraydraw',
499460
description: [
500461
'Sets the background color of the hover label.',
@@ -504,7 +465,6 @@ module.exports = templatedArray('annotation', {
504465
},
505466
bordercolor: {
506467
valType: 'color',
507-
role: 'style',
508468
editType: 'arraydraw',
509469
description: [
510470
'Sets the border color of the hover label.',
@@ -524,7 +484,6 @@ module.exports = templatedArray('annotation', {
524484
},
525485
captureevents: {
526486
valType: 'boolean',
527-
role: 'info',
528487
editType: 'arraydraw',
529488
description: [
530489
'Determines whether the annotation text box captures mouse move',
@@ -540,7 +499,6 @@ module.exports = templatedArray('annotation', {
540499
_deprecated: {
541500
ref: {
542501
valType: 'string',
543-
role: 'info',
544502
editType: 'calc',
545503
description: [
546504
'Obsolete. Set `xref` and `yref` separately instead.'

‎src/components/annotations3d/attributes.js‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,35 +17,30 @@ module.exports = overrideAll(templatedArray('annotation', {
1717
visible: annAttrs.visible,
1818
x: {
1919
valType: 'any',
20-
role: 'info',
2120
description: [
2221
'Sets the annotation\'s x position.'
2322
].join(' ')
2423
},
2524
y: {
2625
valType: 'any',
27-
role: 'info',
2826
description: [
2927
'Sets the annotation\'s y position.'
3028
].join(' ')
3129
},
3230
z: {
3331
valType: 'any',
34-
role: 'info',
3532
description: [
3633
'Sets the annotation\'s z position.'
3734
].join(' ')
3835
},
3936
ax: {
4037
valType: 'number',
41-
role: 'info',
4238
description: [
4339
'Sets the x component of the arrow tail about the arrow head (in pixels).'
4440
].join(' ')
4541
},
4642
ay: {
4743
valType: 'number',
48-
role: 'info',
4944
description: [
5045
'Sets the y component of the arrow tail about the arrow head (in pixels).'
5146
].join(' ')

‎src/components/calendars/index.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ var ONEDAY = constants.ONEDAY;
1919
var attributes = {
2020
valType: 'enumerated',
2121
values: Object.keys(calendars.calendars),
22-
role: 'info',
2322
editType: 'calc',
2423
dflt: 'gregorian'
2524
};

0 commit comments

Comments
 (0)