sunburst handle no text when using various inside-text-orientation options

Author: archmoj

src/traces/sunburst/plot.js

@@ -151,8 +151,8 @@ function plotOne(gd, cd, element, transitionOpts) {
     var pathSlice = function(d) { return Lib.pathAnnulus(d.rpx0, d.rpx1, d.x0, d.x1, cx, cy); };
     // slice text translate x/y
 
-    var getTargetX = function(d) { return cx + getTextXY(d)[0] * d.transform.rCenter + (d.transform.x || 0); };
-    var getTargetY = function(d) { return cy + getTextXY(d)[1] * d.transform.rCenter + (d.transform.y || 0); };
+    var getTargetX = function(d) { return cx + getTextXY(d)[0] * (d.transform.rCenter || 0) + (d.transform.x || 0); };
+    var getTargetY = function(d) { return cy + getTextXY(d)[1] * (d.transform.rCenter || 0) + (d.transform.y || 0); };
 
     slices = slices.data(sliceData, helpers.getPtId);
 

test/jasmine/tests/sunburst_test.js

@@ -1067,7 +1067,7 @@ describe('Test sunburst restyle:', function() {
         .then(done);
     });
 
-    it('should be able to restyle *textinfo*', function(done) {
+    it('should be able to restyle *textinfo* with various *insidetextorientation*', function(done) {
         var mock = {
             data: [{
                 type: 'sunburst',
@@ -1121,6 +1121,27 @@ describe('Test sunburst restyle:', function() {
         .then(_assert('show everything', ['Root\n0\nnode0', 'B\n2\nnode2', 'A\n1\nnode1', 'b\n3\nnode3']))
         .then(_restyle({textinfo: null}))
         .then(_assert('back to dflt', ['Root\nnode0', 'B\nnode2', 'A\nnode1', 'b\nnode3']))
+        // now change insidetextorientation to 'horizontal'
+        .then(_restyle({insidetextorientation: 'horizontal'}))
+        .then(_assert('back to dflt', ['Root\nnode0', 'B\nnode2', 'A\nnode1', 'b\nnode3']))
+        .then(_restyle({textinfo: 'none'}))
+        .then(_assert('no textinfo', ['', '', '', '']))
+        .then(_restyle({textinfo: null}))
+        .then(_assert('back to dflt', ['Root\nnode0', 'B\nnode2', 'A\nnode1', 'b\nnode3']))
+        // now change insidetextorientation to 'tangential'
+        .then(_restyle({insidetextorientation: 'tangential'}))
+        .then(_assert('back to dflt', ['Root\nnode0', 'B\nnode2', 'A\nnode1', 'b\nnode3']))
+        .then(_restyle({textinfo: 'none'}))
+        .then(_assert('no textinfo', ['', '', '', '']))
+        .then(_restyle({textinfo: null}))
+        .then(_assert('back to dflt', ['Root\nnode0', 'B\nnode2', 'A\nnode1', 'b\nnode3']))
+        // now change insidetextorientation to 'radial'
+        .then(_restyle({insidetextorientation: 'radial'}))
+        .then(_assert('back to dflt', ['Root\nnode0', 'B\nnode2', 'A\nnode1', 'b\nnode3']))
+        .then(_restyle({textinfo: 'none'}))
+        .then(_assert('no textinfo', ['', '', '', '']))
+        .then(_restyle({textinfo: null}))
+        .then(_assert('back to dflt', ['Root\nnode0', 'B\nnode2', 'A\nnode1', 'b\nnode3']))
         .catch(failTest)
         .then(done);
     });