Merge pull request #5666 from plotly/fix-bar-get-color-mcc

archmoj · web-flow · commit 2b58ca2c13b9 · 2021-05-18T21:50:47.000-04:00
Fix bar get color
diff --git a/src/traces/bar/style.js b/src/traces/bar/style.js
@@ -158,7 +158,7 @@ function getBarColor(cd, trace) {
     if(trace.type === 'waterfall') {
         return trace[cd.dir].marker.color;
     }
-    return cd.mc || trace.marker.color;
+    return cd.mcc || cd.mc || trace.marker.color;
 }
 
 module.exports = {
diff --git a/test/image/baselines/bar-colorscale-colorbar.png b/test/image/baselines/bar-colorscale-colorbar.png
diff --git a/test/image/mocks/bar-colorscale-colorbar.json b/test/image/mocks/bar-colorscale-colorbar.json
@@ -2,6 +2,10 @@
     "data": [
         {
             "type": "bar",
+            "textfont": {
+                "size": 24
+            },
+            "texttemplate": "%{y}",
             "y": [
                 1,
                 2,

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ function getBarColor(cd, trace) {`
`158`	`158`	`if(trace.type === 'waterfall') {`
`159`	`159`	`return trace[cd.dir].marker.color;`
`160`	`160`	`}`
`161`		`- return cd.mc \|\| trace.marker.color;`
	`161`	`+ return cd.mcc \|\| cd.mc \|\| trace.marker.color;`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`module.exports = {`