fix and 🔒 cmid/zmid edits

Author: etpinard

src/components/colorscale/attributes.js

@@ -166,8 +166,8 @@ module.exports = function colorScaleAttrs(context, opts) {
         valType: 'number',
         role: 'info',
         dflt: null,
-        editType: editTypeOverride || 'plot',
-        impliedEdits: minmaxImpliedEdits,
+        editType: 'calc',
+        impliedEdits: autoImpliedEdits,
         description: [
             'Sets the mid-point of the color domain by scaling ', minFull,
             ' and/or ', maxFull, ' to be equidistant to this point.',

src/components/colorscale/defaults.js

@@ -33,10 +33,14 @@ module.exports = function colorScaleDefaults(traceIn, traceOut, layout, coerce,
     var minIn = containerIn[cLetter + 'min'];
     var maxIn = containerIn[cLetter + 'max'];
     var validMinMax = isNumeric(minIn) && isNumeric(maxIn) && (minIn < maxIn);
-    coerce(prefix + cLetter + 'auto', !validMinMax);
-    coerce(prefix + cLetter + 'min');
-    coerce(prefix + cLetter + 'max');
-    coerce(prefix + cLetter + 'mid');
+    var auto = coerce(prefix + cLetter + 'auto', !validMinMax);
+
+    if(auto) {
+        coerce(prefix + cLetter + 'mid');
+    } else {
+        coerce(prefix + cLetter + 'min');
+        coerce(prefix + cLetter + 'max');
+    }
 
     // handles both the trace case (autocolorscale is false by default) and
     // the marker and marker.line case (autocolorscale is true by default)

test/jasmine/tests/plot_api_test.js

@@ -1195,6 +1195,77 @@ describe('Test plot api', function() {
             .then(done);
         });
 
+        it('turns on cauto when cmid is edited', function(done) {
+            function _assert(msg, exp) {
+                return function() {
+                    var mk = gd._fullData[0].marker;
+                    for(var k in exp) {
+                        expect(mk[k]).toBe(exp[k], [msg, k].join(' - '));
+                    }
+                };
+            }
+
+            function _restyle(arg) {
+                return function() { return Plotly.restyle(gd, arg); };
+            }
+
+            Plotly.plot(gd, [{
+                mode: 'markers',
+                y: [1, 2, 1],
+                marker: { color: [1, -1, 4] }
+            }])
+            .then(_assert('base', {
+                cauto: true,
+                cmid: undefined,
+                cmin: -1,
+                cmax: 4
+            }))
+            .then(_restyle({'marker.cmid': 0}))
+            .then(_assert('set cmid=0', {
+                cauto: true,
+                cmid: 0,
+                cmin: -4,
+                cmax: 4
+            }))
+            .then(_restyle({'marker.cmid': -2}))
+            .then(_assert('set cmid=-2', {
+                cauto: true,
+                cmid: -2,
+                cmin: -8,
+                cmax: 4
+            }))
+            .then(_restyle({'marker.cmid': 2}))
+            .then(_assert('set cmid=2', {
+                cauto: true,
+                cmid: 2,
+                cmin: -1,
+                cmax: 5
+            }))
+            .then(_restyle({'marker.cmin': 0}))
+            .then(_assert('set cmin=0', {
+                cauto: false,
+                cmid: undefined,
+                cmin: 0,
+                cmax: 5
+            }))
+            .then(_restyle({'marker.cmax': 10}))
+            .then(_assert('set cmin=0 + cmax=10', {
+                cauto: false,
+                cmid: undefined,
+                cmin: 0,
+                cmax: 10
+            }))
+            .then(_restyle({'marker.cauto': true, 'marker.cmid': null}))
+            .then(_assert('back to cauto=true', {
+                cauto: true,
+                cmid: undefined,
+                cmin: -1,
+                cmax: 4
+            }))
+            .catch(failTest)
+            .then(done);
+        });
+
         it('turns off autobin when you edit bin specs', function(done) {
             // test retained (modified) for backward compat with new autobin logic
             var start0 = 0.2;