add editInChartStudio modebar button + showEditInChartStudio config opt

Author: etpinard

src/components/modebar/buttons.js

@@ -89,6 +89,15 @@ modeBarButtons.sendDataToCloud = {
     }
 };
 
+modeBarButtons.editInChartStudio = {
+    name: 'editInChartStudio',
+    title: function(gd) { return _(gd, 'Edit in Chart Studio'); },
+    icon: Icons.pencil,
+    click: function(gd) {
+        Plots.sendDataToCloud(gd);
+    }
+};
+
 modeBarButtons.zoom2d = {
     name: 'zoom2d',
     title: function(gd) { return _(gd, 'Zoom'); },

src/components/modebar/manage.js

@@ -59,22 +59,20 @@ module.exports = function manageModeBar(gd) {
     } else if(!context.displayModeBar && context.watermark) {
         buttonGroups = [];
     } else {
-        buttonGroups = getButtonGroups(
-            gd,
-            context.modeBarButtonsToRemove,
-            context.modeBarButtonsToAdd,
-            context.showSendToCloud
-        );
+        buttonGroups = getButtonGroups(gd);
     }
 
     if(modeBar) modeBar.update(gd, buttonGroups);
     else fullLayout._modeBar = createModeBar(gd, buttonGroups);
 };
 
 // logic behind which buttons are displayed by default
-function getButtonGroups(gd, buttonsToRemove, buttonsToAdd, showSendToCloud) {
+function getButtonGroups(gd) {
     var fullLayout = gd._fullLayout;
     var fullData = gd._fullData;
+    var context = gd._context;
+    var buttonsToRemove = context.modeBarButtonsToRemove;
+    var buttonsToAdd = context.modeBarButtonsToAdd;
 
     var hasCartesian = fullLayout._has('cartesian');
     var hasGL3D = fullLayout._has('gl3d');
@@ -106,7 +104,8 @@ function getButtonGroups(gd, buttonsToRemove, buttonsToAdd, showSendToCloud) {
 
     // buttons common to all plot types
     var commonGroup = ['toImage'];
-    if(showSendToCloud) commonGroup.push('sendDataToCloud');
+    if(context.showEditInChartStudio) commonGroup.push('editInChartStudio');
+    else if(context.showSendToCloud) commonGroup.push('sendDataToCloud');
     addGroup(commonGroup);
 
     var zoomGroup = [];

src/plot_api/plot_config.js

@@ -257,6 +257,15 @@ var configAttributes = {
             'until you arrive at the Chart Studio and explicitly click "Save".'
         ].join(' ')
     },
+    showEditInChartStudio: {
+        valType: 'boolean',
+        dflt: false,
+        description: [
+            'Same as `showSendToCloud`, but use a pencil icon instead of a floppy-disk.',
+            'Note that if both `showSendToCloud` and `showEditInChartStudio` are turned,',
+            'only `showEditInChartStudio` will be honored.'
+        ].join(' ')
+    },
     modeBarButtonsToRemove: {
         valType: 'any',
         dflt: [],

test/jasmine/tests/modebar_test.js

@@ -52,6 +52,7 @@ describe('ModeBar', function() {
             _context: {
                 displaylogo: true,
                 showSendToCloud: false,
+                showEditInChartStudio: false,
                 displayModeBar: true,
                 modeBarButtonsToRemove: [],
                 modeBarButtonsToAdd: [],
@@ -804,7 +805,7 @@ describe('ModeBar', function() {
             expect(countLogo(gd._fullLayout._modeBar)).toEqual(0);
         });
 
-        it('displays/hides cloud link according to showSendToCloud config arg', function() {
+        it('displays/hides cloud link according to showSendToCloud and/or showEditInChartStudio config arg', function() {
             var gd = getMockGraphInfo();
             gd._fullLayout._basePlotModules = [{ name: 'pie' }];
             gd._fullData = [{type: 'pie'}];
@@ -815,11 +816,28 @@ describe('ModeBar', function() {
             ]), 1);
 
             gd._context.showSendToCloud = true;
+            gd._context.showEditInChartStudio = false;
             manageModeBar(gd);
             checkButtons(gd._fullLayout._modeBar, getButtons([
                 ['toImage', 'sendDataToCloud'],
                 ['hoverClosestPie']
             ]), 1);
+
+            gd._context.showSendToCloud = false;
+            gd._context.showEditInChartStudio = true;
+            manageModeBar(gd);
+            checkButtons(gd._fullLayout._modeBar, getButtons([
+                ['toImage', 'editInChartStudio'],
+                ['hoverClosestPie']
+            ]), 1);
+
+            gd._context.showSendToCloud = true;
+            gd._context.showEditInChartStudio = true;
+            manageModeBar(gd);
+            checkButtons(gd._fullLayout._modeBar, getButtons([
+                ['toImage', 'editInChartStudio'],
+                ['hoverClosestPie']
+            ]), 1);
         });
 
         it('always displays the logo if watermark config arg is true', function() {