fix insiderange react

Author: archmoj

src/plot_api/helpers.js

@@ -72,6 +72,9 @@ exports.cleanLayout = function(layout) {
                 ax.autorange = true;
                 ax.rangemode = 'tozero';
             }
+
+            if(ax.insiderange) delete ax.range;
+
             delete ax.islog;
             delete ax.isdate;
             delete ax.categories; // replaced by _categories

src/plot_api/plot_api.js

@@ -355,7 +355,7 @@ function _doPlot(gd, data, layout, config) {
             drawAxes,
             function insideTickLabelsAutorange(gd) {
                 if(gd._fullLayout._insideTickLabelsUpdaterange) {
-                    relayout(gd, gd._fullLayout._insideTickLabelsUpdaterange).then(function() {
+                    return relayout(gd, gd._fullLayout._insideTickLabelsUpdaterange).then(function() {
                         Axes.saveRangeInitial(gd, true);
 
                         gd._fullLayout._insideTickLabelsUpdaterange = undefined;

test/jasmine/tests/axes_test.js

@@ -1628,8 +1628,7 @@ describe('Test axes', function() {
                 expect(gd._fullLayout.xaxis.range).toBeCloseToArray([-0.132, 2]);
 
                 return Plotly.relayout(gd, {
-                    'xaxis.insiderange': [1, 3],
-                    'xaxis.range': null
+                    'xaxis.insiderange': [1, 3]
                 });
             }).then(function() {
                 expect(gd._fullLayout.xaxis.range).toBeCloseToArray([0.867, 3]);
@@ -7955,6 +7954,40 @@ describe('more react tests', function() {
         })
         .then(done, done.fail);
     });
+
+    it('insiderange react to new data', function(done) {
+        var layout = {
+            xaxis: {
+                insiderange: [0, 2]
+            },
+            yaxis: {
+                ticklabelposition: 'inside'
+            },
+            plot_bgcolor: 'lightgray',
+            width: 600,
+            height: 600
+        };
+
+        var data1 = [{
+            y: [1, 3, 2]
+        }];
+
+        var data2 = [{
+            y: [1000, 3000, 2000]
+        }];
+
+        var fig1 = {data: data1, layout: layout};
+        var fig2 = {data: data2, layout: layout};
+
+        Plotly.newPlot(gd, fig1)
+        .then(function() {
+            expect(gd._fullLayout.xaxis.range).toBeCloseToArray([-0.132, 2]);
+
+            return Plotly.react(gd, fig2);
+        }).then(function() {
+            expect(gd._fullLayout.xaxis.range).toBeCloseToArray([-0.179, 2]);
+        }).then(done, done.fail);
+    });
 });
 
 describe('category preservation tests on gd passed to Plotly.react()', function() {