fixup selected textfont.color logic + add a few more tests

Author: etpinard

src/traces/scattergl/index.js

@@ -930,9 +930,10 @@ function styleTextSelection(cd) {
         var hasArrayBase = Array.isArray(base);
         opts.color = new Array(stash.count);
 
+
         for(i = 0; i < els.length; i++) {
             j = els[i];
-            opts.color[j] = stc || hasArrayBase ? base[j] : base;
+            opts.color[j] = stc || (hasArrayBase ? base[j] : base);
         }
         for(i = 0; i < unels.length; i++) {
             j = unels[i];

test/jasmine/tests/gl2d_click_test.js

@@ -792,6 +792,32 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
                 ]
             });
         })
+        .then(function() {
+            return Plotly.restyle(gd, 'selected.textfont.color', 'red');
+        })
+        .then(function() { return select([[100, 100], [250, 250]]); })
+        .then(function() {
+            _assertGlTextOpts('after selection - with set selected.textfont.color', {
+                rgba: [
+                    [
+                        68, 68, 68, 255,
+                        68, 68, 68, 255,
+                        68, 68, 68, 255,
+                    ],
+                    [
+                        68, 68, 68, 255,
+                        // this is the selected pt!
+                        255, 0, 0, 255,
+                        68, 68, 68, 255
+                    ],
+                    [
+                        68, 68, 68, 255,
+                        68, 68, 68, 255,
+                        68, 68, 68, 255
+                    ]
+                ]
+            });
+        })
         .catch(failTest)
         .then(done);
     });
@@ -851,6 +877,27 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
                 ]
             });
         })
+        .then(function() {
+            return Plotly.restyle(gd, 'selected.textfont.color', 'red');
+        })
+        .then(function() { return select([[100, 10], [250, 100]]); })
+        .then(function() {
+            _assertGlTextOpts('after selection - with set selected.textfont.color', {
+                rgba: [
+                    [
+                        255, 0, 0, 255,
+                        0, 0, 255, 255,
+                        0, 128, 0, 255
+                    ],
+                    [
+                        0, 0, 0, 255,
+                        // this is the selected pt!
+                        255, 0, 0, 255,
+                        237, 97, 0, 255
+                    ]
+                ]
+            });
+        })
         .catch(failTest)
         .then(done);
     });