factor out is-valid-range logic into setConvert helper

Author: etpinard

src/components/rangeslider/defaults.js

@@ -8,8 +8,6 @@
 
 'use strict';
 
-var isNumeric = require('fast-isnumeric');
-
 var Lib = require('../../lib');
 var attributes = require('./attributes');
 
@@ -37,11 +35,7 @@ module.exports = function handleDefaults(layoutIn, layoutOut, axName) {
     coerce('borderwidth');
     coerce('thickness');
 
-    coerce('autorange', !(
-        (containerIn.range || []).length === 2 &&
-        isNumeric(axOut.r2l(containerIn.range[0])) &&
-        isNumeric(axOut.r2l(containerIn.range[1]))
-    ));
+    coerce('autorange', !axOut.isValidRange(containerIn.range));
     coerce('range');
 
     // Expand slider range to the axis range

src/plots/cartesian/axis_defaults.js

@@ -9,7 +9,6 @@
 
 'use strict';
 
-var isNumeric = require('fast-isnumeric');
 var colorMix = require('tinycolor2').mix;
 
 var Registry = require('../../registry');
@@ -93,12 +92,7 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
         color: dfltFontColor
     });
 
-    var validRange = (
-        (containerIn.range || []).length === 2 &&
-        isNumeric(containerOut.r2l(containerIn.range[0])) &&
-        isNumeric(containerOut.r2l(containerIn.range[1]))
-    );
-    var autoRange = coerce('autorange', !validRange);
+    var autoRange = coerce('autorange', !containerOut.isValidRange(containerIn.range));
 
     if(autoRange) coerce('rangemode');
 

src/plots/cartesian/set_convert.js

@@ -402,6 +402,15 @@ module.exports = function setConvert(ax) {
         return arrayOut;
     };
 
+    ax.isValidRange = function(range) {
+        return (
+            Array.isArray(range) &&
+            range.length === 2 &&
+            isNumeric(ax.r2l(range[0])) &&
+            isNumeric(ax.r2l(range[1]))
+        );
+    };
+
     // for autoranging: arrays of objects:
     //      {val: axis value, pad: pixel padding}
     // on the low and high sides

test/jasmine/tests/axes_test.js

@@ -413,6 +413,37 @@ describe('Test axes', function() {
             expect(layoutOut.xaxis.calendar).toBe('coptic');
             expect(layoutOut.yaxis.calendar).toBe('thai');
         });
+
+        it('should set autorange to true when input range is invalid', function() {
+            layoutIn = {
+                xaxis: { range: 'not-gonna-work' },
+                xaxis2: { range: [1, 2, 3] },
+                yaxis: { range: ['a', 2] },
+                yaxis2: { range: [1, 'b'] },
+                yaxis3: { range: [null, {}] }
+            };
+
+            supplyLayoutDefaults(layoutIn, layoutOut, fullData);
+
+            Axes.list({ _fullLayout: layoutOut }).forEach(function(ax) {
+                expect(ax.autorange).toBe(true, ax._name);
+            });
+        });
+
+        it('should set autorange to false when input range is valid', function() {
+            layoutIn = {
+                xaxis: { range: [1, 2] },
+                xaxis2: { range: [-2, 1] },
+                yaxis: { range: ['1', 2] },
+                yaxis2: { range: [1, '2'] }
+            };
+
+            supplyLayoutDefaults(layoutIn, layoutOut, fullData);
+
+            Axes.list({ _fullLayout: layoutOut }).forEach(function(ax) {
+                expect(ax.autorange).toBe(false, ax._name);
+            });
+        });
     });
 
     describe('categoryorder', function() {