organize modebar attributes and defaults and register it

Author: archmoj

src/components/modebar/attributes.js

@@ -0,0 +1,41 @@
+'use strict';
+
+module.exports = {
+    editType: 'modebar',
+
+    modebar: {
+        editType: 'modebar',
+
+        orientation: {
+            valType: 'enumerated',
+            values: ['v', 'h'],
+            dflt: 'h',
+            editType: 'modebar',
+            description: 'Sets the orientation of the modebar.'
+        },
+        bgcolor: {
+            valType: 'color',
+            editType: 'modebar',
+            description: 'Sets the background color of the modebar.'
+        },
+        color: {
+            valType: 'color',
+            editType: 'modebar',
+            description: 'Sets the color of the icons in the modebar.'
+        },
+        activecolor: {
+            valType: 'color',
+            editType: 'modebar',
+            description: 'Sets the color of the active or hovered on icons in the modebar.'
+        },
+        uirevision: {
+            valType: 'any',
+            editType: 'none',
+            description: [
+                'Controls persistence of user-driven changes related to the modebar,',
+                'including `hovermode`, `dragmode`, and `showspikes` at both the',
+                'root level and inside subplots. Defaults to `layout.uirevision`.'
+            ].join(' ')
+        },
+    }
+};

src/components/modebar/defaults.js

@@ -0,0 +1,18 @@
+'use strict';
+
+var Lib = require('../../lib');
+var Color = require('../color');
+var attributes = require('./attributes');
+
+module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) {
+    function coerce(attr, dflt) {
+        return Lib.coerce(layoutIn, layoutOut, attributes, attr, dflt);
+    }
+
+    coerce('modebar.orientation');
+    coerce('modebar.bgcolor', Color.addOpacity(layoutOut.paper_bgcolor, 0.5));
+    var defaultColor = Color.contrast(Color.rgb(layoutOut.modebar.bgcolor));
+    coerce('modebar.color', Color.addOpacity(defaultColor, 0.3));
+    coerce('modebar.activecolor', Color.addOpacity(defaultColor, 0.7));
+    coerce('modebar.uirevision', layoutOut.uirevision);
+};

src/components/modebar/index.js

@@ -1,3 +1,11 @@
 'use strict';
 
-exports.manage = require('./manage');
+module.exports = {
+    moduleType: 'component',
+    name: 'modebar',
+
+    layoutAttributes: require('./attributes'),
+    supplyLayoutDefaults: require('./defaults'),
+
+    manage: require('./manage')
+};

src/core.js

@@ -44,7 +44,8 @@ register([
     require('./components/grid'),
     require('./components/errorbars'),
     require('./components/colorscale'),
-    require('./components/colorbar')
+    require('./components/colorbar'),
+    require('./components/modebar')
 ]);
 
 // locales en and en-US are required for default behavior

src/plots/layout_attributes.js

@@ -388,40 +388,6 @@ module.exports = {
             'make an item with matching `templateitemname` and `visible: false`.'
         ].join(' ')
     },
-    modebar: {
-        orientation: {
-            valType: 'enumerated',
-            values: ['v', 'h'],
-            dflt: 'h',
-            editType: 'modebar',
-            description: 'Sets the orientation of the modebar.'
-        },
-        bgcolor: {
-            valType: 'color',
-            editType: 'modebar',
-            description: 'Sets the background color of the modebar.'
-        },
-        color: {
-            valType: 'color',
-            editType: 'modebar',
-            description: 'Sets the color of the icons in the modebar.'
-        },
-        activecolor: {
-            valType: 'color',
-            editType: 'modebar',
-            description: 'Sets the color of the active or hovered on icons in the modebar.'
-        },
-        uirevision: {
-            valType: 'any',
-            editType: 'none',
-            description: [
-                'Controls persistence of user-driven changes related to the modebar,',
-                'including `hovermode`, `dragmode`, and `showspikes` at both the',
-                'root level and inside subplots. Defaults to `layout.uirevision`.'
-            ].join(' ')
-        },
-        editType: 'modebar'
-    },
 
     newshape: drawNewShapeAttrs.newshape,
     activeshape: drawNewShapeAttrs.activeshape,

src/plots/plots.js

@@ -1517,12 +1517,10 @@ plots.supplyLayoutGlobalDefaults = function(layoutIn, layoutOut, formatObj) {
     coerce('editrevision', uirevision);
     coerce('selectionrevision', uirevision);
 
-    coerce('modebar.orientation');
-    coerce('modebar.bgcolor', Color.addOpacity(layoutOut.paper_bgcolor, 0.5));
-    var modebarDefaultColor = Color.contrast(Color.rgb(layoutOut.modebar.bgcolor));
-    coerce('modebar.color', Color.addOpacity(modebarDefaultColor, 0.3));
-    coerce('modebar.activecolor', Color.addOpacity(modebarDefaultColor, 0.7));
-    coerce('modebar.uirevision', uirevision);
+    Registry.getComponentMethod(
+        'modebar',
+        'supplyLayoutDefaults'
+    )(layoutIn, layoutOut);
 
     Registry.getComponentMethod(
         'shapes',