address minor PR comments

- guard against empty subplot list in modebar button handlers
- fix 'when' -> 'went' typo in error msg
- guard against (potential) infinite fitbounds scales
- improve `geojson` attr description
- fixup `projection.rotation` fallback in an assertion wrapper

Author: etpinard

src/components/modebar/buttons.js

@@ -303,7 +303,7 @@ function handleDrag3d(gd, ev) {
     var button = ev.currentTarget;
     var attr = button.getAttribute('data-attr');
     var val = button.getAttribute('data-val') || true;
-    var sceneIds = gd._fullLayout._subplots.gl3d;
+    var sceneIds = gd._fullLayout._subplots.gl3d || [];
     var layoutUpdate = {};
 
     var parts = attr.split('.');
@@ -468,7 +468,7 @@ function handleGeo(gd, ev) {
     var attr = button.getAttribute('data-attr');
     var val = button.getAttribute('data-val') || true;
     var fullLayout = gd._fullLayout;
-    var geoIds = fullLayout._subplots.geo;
+    var geoIds = fullLayout._subplots.geo || [];
 
     for(var i = 0; i < geoIds.length; i++) {
         var id = geoIds[i];

src/lib/geo_location_utils.js

@@ -187,14 +187,14 @@ function feature2polygons(feature) {
 }
 
 function getTraceGeojson(trace) {
-    var geojsonIn = typeof trace.geojson === 'string' ?
-        (window.PlotlyGeoAssets || {})[trace.geojson] :
-        trace.geojson;
+    var g = trace.geojson;
+    var PlotlyGeoAssets = window.PlotlyGeoAssets || {};
+    var geojsonIn = typeof g === 'string' ? PlotlyGeoAssets[g] : g;
 
     // This should not happen, but just in case something goes
     // really wrong when fetching the GeoJSON
     if(!isPlainObject(geojsonIn)) {
-        loggers.error('Oops ... something when wrong when fetching ' + trace.geojson);
+        loggers.error('Oops ... something went wrong when fetching ' + g);
         return false;
     }
 

src/plots/geo/geo.js

@@ -282,7 +282,12 @@ proto.updateProjection = function(geoCalcData, fullLayout) {
             (b[1][0] - b[0][0]) / (b2[1][0] - b2[0][0]),
             (b[1][1] - b[0][1]) / (b2[1][1] - b2[0][1])
         );
-        projection.scale(k2 * s);
+
+        if(isFinite(k2)) {
+            projection.scale(k2 * s);
+        } else {
+            Lib.warn('Something went wrong during' + this.id + 'fitbounds computations.');
+        }
     } else {
         // adjust projection to user setting
         projection.scale(projLayout.scale * s);

src/traces/choropleth/attributes.js

@@ -38,9 +38,9 @@ module.exports = extendFlat({
             'Sets optional GeoJSON data associated with this trace.',
             'If not given, the features on the base map are used.',
 
-            'Can be set as a valid GeoJSON object or as URL string',
-            'Note that we only accept GeoJSON of type *FeatureCollection* and *Feature*',
-            'with geometries of type *Polygon* and *MultiPolygon*.'
+            'It can be set as a valid GeoJSON object or as a URL string.',
+            'Note that we only accept GeoJSONs of type *FeatureCollection* or *Feature*',
+            'with geometries of type *Polygon* or *MultiPolygon*.'
 
             // TODO add topojson support with additional 'topojsonobject' attr?
             // https://github.com/topojson/topojson-specification/blob/master/README.md

src/traces/choroplethmapbox/attributes.js

@@ -45,9 +45,10 @@ module.exports = extendFlat({
         editType: 'calc',
         description: [
             'Sets the GeoJSON data associated with this trace.',
-            'Can be set as a valid GeoJSON object or as URL string',
-            'Note that we only accept GeoJSON of type *FeatureCollection* and *Feature*',
-            'with geometries of type *Polygon* and *MultiPolygon*.'
+
+            'It can be set as a valid GeoJSON object or as a URL string.',
+            'Note that we only accept GeoJSONs of type *FeatureCollection* or *Feature*',
+            'with geometries of type *Polygon* or *MultiPolygon*.'
         ].join(' ')
     },
     featureidkey: extendFlat({}, choroplethAttrs.featureidkey, {

src/traces/scattergeo/attributes.js

@@ -62,9 +62,9 @@ module.exports = overrideAll({
             'Sets optional GeoJSON data associated with this trace.',
             'If not given, the features on the base map are used when `locations` is set.',
 
-            'Can be set as a valid GeoJSON object or as URL string',
-            'Note that we only accept GeoJSON of type *FeatureCollection* and *Feature*',
-            'with geometries of type *Polygon* and *MultiPolygon*.'
+            'It can be set as a valid GeoJSON object or as a URL string.',
+            'Note that we only accept GeoJSONs of type *FeatureCollection* or *Feature*',
+            'with geometries of type *Polygon* or *MultiPolygon*.'
 
             // TODO add topojson support with additional 'topojsonobject' attr?
             // https://github.com/topojson/topojson-specification/blob/master/README.md

test/jasmine/tests/choroplethmapbox_test.js

@@ -158,7 +158,7 @@ describe('Test choroplethmapbox convert:', function() {
             geojson: 'url'
         });
 
-        expect(loggers.error).toHaveBeenCalledWith('Oops ... something when wrong when fetching url');
+        expect(loggers.error).toHaveBeenCalledWith('Oops ... something went wrong when fetching url');
         expectBlank(opts);
     });
 

test/jasmine/tests/geo_test.js

@@ -2114,7 +2114,7 @@ describe('Test geo zoom/pan/drag interactions:', function() {
             var msg = '[' + step + '] ';
 
             var geoLayout = gd._fullLayout.geo;
-            var rotation = geoLayout.projection.rotation || [];
+            var rotation = geoLayout.projection.rotation || {};
             var scale = geoLayout.projection.scale;
 
             expect([rotation.lon, rotation.lat]).toBeCloseToArray(attr[0], -0.5, msg + 'rotation.(lon|lat)');