code cleanup

Author: keeganmccallum

src/traces/bar/set_positions.js

@@ -144,7 +144,7 @@ module.exports = function setPositions(gd, plotinfo) {
                 for(j = 0; j < ti.length; j++) {
                     sv = Math.round(ti[j].p / sumround);
                     // store the negative sum value for p at the same key, with sign flipped
-                    if (relative && ti[j].s < 0) sv = -Math.round(ti[j].p / sumround);
+                    if (relative && ti[j].s < 0) sv = -sv;
                     var previousSum = sums[sv] || 0;
                     if(stack || relative) ti[j].b = previousSum;
                     barEnd = ti[j].b + ti[j].s;
@@ -172,8 +172,8 @@ module.exports = function setPositions(gd, plotinfo) {
                     ti = gd.calcdata[bl[i]];
                     for(j = 0; j < ti.length; j++) {
                         relAndNegative = relative && ti[j].s < 0;
-                        sv = Math.round(ti[j].p/sumround);
-                        if (relAndNegative) sv = -Math.round(ti[j].p/sumround);  // locate negative sum amount for this p val
+                        sv = Math.round(ti[j].p / sumround);
+                        if (relAndNegative) sv = -sv;  // locate negative sum amount for this p val
                         scale = top / sums[sv];
                         if (relAndNegative) scale *= -1; // preserve sign if negative
                         ti[j].b *= scale;