rename Lib.fillUnique -> Lib.pushUnique

Author: etpinard

src/lib/index.js

@@ -336,7 +336,7 @@ lib.noneOrAll = function(containerIn, containerOut, attrList) {
 };
 
 /**
- * Fill with unique items
+ * Push array with unique items
  *
  * @param {array} array
  *  array to be filled
@@ -346,7 +346,7 @@ lib.noneOrAll = function(containerIn, containerOut, attrList) {
  *  ref to array (now possibly containing one more item)
  *
  */
-lib.fillUnique = function(array, item) {
+lib.pushUnique = function(array, item) {
     if(item && array.indexOf(item) === -1) array.push(item);
 
     return array;

src/plots/cartesian/layout_defaults.js

@@ -95,7 +95,7 @@ module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) {
     // make sure that plots with orphan cartesian axes
     // are considered 'cartesian'
     if(xaListCartesian.length && yaListCartesian.length) {
-        Lib.fillUnique(layoutOut._basePlotModules, Plots.subplotsRegistry.cartesian);
+        Lib.pushUnique(layoutOut._basePlotModules, Plots.subplotsRegistry.cartesian);
     }
 
     function axSort(a, b) {

src/plots/plots.js

@@ -485,8 +485,8 @@ plots.supplyDefaults = function(gd) {
         if(!_module) continue;
 
         // fill in module lists
-        Lib.fillUnique(modules, _module);
-        Lib.fillUnique(basePlotModules, fullTrace._module.basePlotModule);
+        Lib.pushUnique(modules, _module);
+        Lib.pushUnique(basePlotModules, fullTrace._module.basePlotModule);
     }
 
     // attach helper method to check whether a plot type is present on graph

test/jasmine/tests/lib_test.js

@@ -857,42 +857,42 @@ describe('Test lib.js:', function() {
         });
     });
 
-    describe('fillUnique', function() {
+    describe('pushUnique', function() {
 
         beforeEach(function() {
             this.obj = { a: 'A' };
             this.array = ['a', 'b', 'c', this.obj];
         });
 
         it('should fill new items in array', function() {
-            var out = Lib.fillUnique(this.array, 'd');
+            var out = Lib.pushUnique(this.array, 'd');
 
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }, 'd']);
             expect(this.array).toBe(out);
         });
 
         it('should ignore falsy items', function() {
-            Lib.fillUnique(this.array, false);
+            Lib.pushUnique(this.array, false);
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }]);
 
-            Lib.fillUnique(this.array, undefined);
+            Lib.pushUnique(this.array, undefined);
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }]);
 
-            Lib.fillUnique(this.array, 0);
+            Lib.pushUnique(this.array, 0);
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }]);
 
-            Lib.fillUnique(this.array, null);
+            Lib.pushUnique(this.array, null);
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }]);
 
-            Lib.fillUnique(this.array, '');
+            Lib.pushUnique(this.array, '');
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }]);
         });
 
         it('should ignore item already in array', function() {
-            Lib.fillUnique(this.array, 'a');
+            Lib.pushUnique(this.array, 'a');
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }]);
 
-            Lib.fillUnique(this.array, this.obj);
+            Lib.pushUnique(this.array, this.obj);
             expect(this.array).toEqual(['a', 'b', 'c', { a: 'A' }]);
 
         });