fixup calcInverseTransform function and rename domRectsAreEqual

Author: archmoj

src/lib/dom.js

@@ -150,15 +150,15 @@ function isTransformableElement(element) {
     return element && (element instanceof Element || element instanceof HTMLElement);
 }
 
-function domRectsAreEqual(a, b) {
+function equalDomRects(a, b) {
     return (
         a && b &&
-        a.left === b.left &&
+        a.x === b.x &&
+        a.y === b.y &&
         a.top === b.top &&
+        a.left === b.left &&
         a.right === b.right &&
-        a.bottom === b.bottom &&
-        a.x === b.x &&
-        a.y === b.y
+        a.bottom === b.bottom
     );
 }
 
@@ -172,5 +172,5 @@ module.exports = {
     getFullTransformMatrix: getFullTransformMatrix,
     getElementTransformMatrix: getElementTransformMatrix,
     getElementAndAncestors: getElementAndAncestors,
-    domRectsAreEqual: domRectsAreEqual
+    equalDomRects: equalDomRects
 };

src/lib/index.js

@@ -151,7 +151,7 @@ lib.deleteRelatedStyleRule = domModule.deleteRelatedStyleRule;
 lib.getFullTransformMatrix = domModule.getFullTransformMatrix;
 lib.getElementTransformMatrix = domModule.getElementTransformMatrix;
 lib.getElementAndAncestors = domModule.getElementAndAncestors;
-lib.domRectsAreEqual = domModule.domRectsAreEqual;
+lib.equalDomRects = domModule.equalDomRects;
 
 lib.clearResponsive = require('./clear_responsive');
 

src/plot_api/plot_api.js

@@ -3707,17 +3707,16 @@ function purge(gd) {
 }
 
 // determines if the graph div requires a recalculation of its inverse matrix transforms by comparing old + new bounding boxes.
-function calcInverseTransform(gd, newBBox) {
-    gd = Lib.getGraphDiv(gd);
+function calcInverseTransform(gd) {
     var fullLayout = gd._fullLayout;
-    if(!newBBox) newBBox = gd.getBoundingClientRect();
 
-    if(Lib.domRectsAreEqual(newBBox, fullLayout._lastBBox)) return;
+    var newBBox = gd.getBoundingClientRect();
+    if(Lib.equalDomRects(newBBox, fullLayout._lastBBox)) return;
 
     var m = fullLayout._inverseTransform = Lib.inverseTransformMatrix(Lib.getFullTransformMatrix(gd));
     fullLayout._inverseScaleX = Math.sqrt(m[0][0] * m[0][0] + m[0][1] * m[0][1] + m[0][2] * m[0][2]);
     fullLayout._inverseScaleY = Math.sqrt(m[1][0] * m[1][0] + m[1][1] * m[1][1] + m[1][2] * m[1][2]);
-    fullLayout._lastBBox = gd.getBoundingClientRect();
+    fullLayout._lastBBox = newBBox;
 }
 
 // -------------------------------------------------------