match lowercase and improve test

Author: archmoj

src/components/modebar/manage.js

@@ -75,9 +75,12 @@ function getButtonGroups(gd) {
 
     function match(name, B) {
         if(typeof B === 'string') {
-            if(B === name) return true;
+            if(B.toLowerCase() === name.toLowerCase()) return true;
         } else {
-            if(B.name === name || B._cat === name) return true;
+            var v0 = B.name;
+            var v1 = (B._cat || B.name);
+
+            if(v0 === name || v1 === name.toLowerCase()) return true;
         }
         return false;
     }

test/jasmine/tests/modebar_test.js

@@ -1727,24 +1727,26 @@ describe('ModeBar', function() {
             .then(done, done.fail);
         });
 
-        it('add button if removed by layout and added by config', function(done) {
-            function countButtons() {
-                var modeBarEl = gd._fullLayout._modeBar.element;
-                return d3Select(modeBarEl).selectAll('a.modebar-btn').size();
-            }
-
-            var initial = 10;
-            Plotly.newPlot(gd, [{y: [1, 2]}], {
-                modebar: {
-                    remove: 'zoom'
+        ['zoom', 'zoomin', 'zoomOut'].forEach(function(t) {
+            it('add ' + t + ' button if removed by layout and added by config', function(done) {
+                function countButtons() {
+                    var modeBarEl = gd._fullLayout._modeBar.element;
+                    return d3Select(modeBarEl).selectAll('a.modebar-btn').size();
                 }
-            }, {
-                modeBarButtonsToAdd: ['zoom']
-            })
-            .then(function() {
-                expect(countButtons()).toBe(initial);
-            })
-            .then(done, done.fail);
+
+                var initial = 10;
+                Plotly.newPlot(gd, [{y: [1, 2]}], {
+                    modebar: {
+                        remove: t
+                    }
+                }, {
+                    modeBarButtonsToAdd: [t]
+                })
+                .then(function() {
+                    expect(countButtons()).toBe(initial);
+                })
+                .then(done, done.fail);
+            });
         });
 
         it('remove button if added by layout and removed by config', function(done) {